Paths

Table of Contentst

Differential D19125

Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths"
ClosedPublic
Actions

Authored by epriestley on Feb 22 2018, 6:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 5:37 AM

	Unknown Object (File)
	Wed, Jan 29, 4:41 AM

	Unknown Object (File)
	Tue, Jan 28, 1:26 AM

	Unknown Object (File)
	Sat, Jan 25, 3:24 PM

	Unknown Object (File)
	Sat, Jan 25, 3:24 PM

	Unknown Object (File)
	Sat, Jan 25, 3:24 PM

	Unknown Object (File)
	Sat, Jan 25, 12:18 AM

	Unknown Object (File)
	Sat, Jan 25, 12:18 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13077: Plans: Phriction modern "v3" APIs, Drafts
T13090: Plans: 2018 Week 8 Bonus Content
Commits: rP4cb62ca0d6ae: Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths"

Summary

Ref T13090. Ref T13077. This adds parentPaths and ancestorPaths constraints to phriction.document.query. These should be a little more usable than the internal slugPrefix / depth stuff -- that's technically more powerful, but requires callers to know more slug normalization rules. We could perhaps expose minDepth / maxDepth in the future.

Test Plan

Ran valid and invalid parentPaths and ancestorPaths queries for /, aaa/, AAA/, etc. Got sensible-seeming results.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 22 2018, 6:55 PM

Harbormaster completed remote builds in B19634: Diff 45825.Feb 22 2018, 6:56 PM

epriestley requested review of this revision.Feb 22 2018, 6:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 8:49 PM

Closed by commit rP4cb62ca0d6ae: Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13090: Plans: 2018 Week 8 Bonus Content.Feb 22 2018, 9:58 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

query/

PhrictionDocumentQuery.php

103 lines

PhrictionDocumentSearchEngine.php

16 lines

Diff 45829

src/applications/phriction/query/PhrictionDocumentQuery.php

Loading...

src/applications/phriction/query/PhrictionDocumentSearchEngine.php

Loading...