Page MenuHomePhabricator

Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths"
ClosedPublic

Authored by epriestley on Feb 22 2018, 6:55 PM.

Details

Summary

Ref T13090. Ref T13077. This adds parentPaths and ancestorPaths constraints to phriction.document.query. These should be a little more usable than the internal slugPrefix / depth stuff -- that's technically more powerful, but requires callers to know more slug normalization rules. We could perhaps expose minDepth / maxDepth in the future.

Test Plan

Ran valid and invalid parentPaths and ancestorPaths queries for /, aaa/, AAA/, etc. Got sensible-seeming results.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 22 2018, 6:55 PM
epriestley requested review of this revision.Feb 22 2018, 6:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.