Differential D19114

Fix incorrect context extraction for relative Phriction links on Phriction pages
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 8:32 PM.

Tags

None

Referenced Files

	F13177367: D19114.diff
	Wed, May 8, 7:39 PM

	Unknown Object (File)
	Mon, Apr 29, 2:43 PM

	Unknown Object (File)
	Mon, Apr 29, 4:57 AM

	Unknown Object (File)
	Sat, Apr 27, 3:20 AM

	Unknown Object (File)
	Fri, Apr 26, 9:06 PM

	Unknown Object (File)
	Thu, Apr 25, 8:29 AM

	Unknown Object (File)
	Wed, Apr 24, 10:45 PM

	Unknown Object (File)
	Fri, Apr 19, 7:24 PM

View All 100 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits: rP66a7ca49b20c: Fix incorrect context extraction for relative Phriction links on Phriction pages

Summary

Ref T13077. This content extraction rule wasn't right and caused rendering on Phriction pages to extract context improperly.

Test Plan

Viewed pages in Phriction with relative links to other documents.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 16 2018, 8:32 PM

Harbormaster completed remote builds in B19607: Diff 45803.Feb 16 2018, 8:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 8:33 PM

epriestley requested review of this revision.

Closed by commit rP66a7ca49b20c: Fix incorrect context extraction for relative Phriction links on Phriction pages (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

markup/

PhrictionRemarkupRule.php

2 lines

Diff 45804

View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php

Fix incorrect context extraction for relative Phriction links on Phriction pagesClosedPublicActions