Add autocomplete for Phriction documents on "[[ ..." in Remarkup
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 5:26 PM.

Details

Reviewers: None
Maniphest Tasks: T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits: rP8771b7d5c40c: Add autocomplete for Phriction documents on "[[ ..." in Remarkup

Summary

Depends on D19107. Ref T13077. The underlying datasource may need some adjustment but this appears to work properly locally.

Test Plan

Typed [[ por locally, was suggested "Porcupine Facts". Typed [[ / ]], saw it render as a reference to the wiki root instead of the install root.

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Feb 16 2018, 5:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:56 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			resources/celerity/map.php (16 lines)
M			src/applications/phriction/typeahead/PhrictionDocumentDatasource.php (2 lines)
M			src/view/form/control/PhabricatorRemarkupControl.php (14 lines)
M			webroot/rsrc/js/phuix/PHUIXAutocomplete.js (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45786	74dcade		Feb 16 2018, 5:26 PM	★	★
Diff 2	45792	f82206a	rP8771b7d5c40cc9bbaf417919c778835d13113878	Feb 16 2018, 5:56 PM	★	★

Status	Author	Revision
Closed	epriestley	D19109 Suggest Phurl URLs on "((..." in Remarkup text areas
Closed	epriestley	D19108 Add autocomplete for Phriction documents on "[[ ..." in Remarkup
Closed	epriestley	D19107 Add a rough Quick Search datasource for Phriction documents
Closed	epriestley	D19106 Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/" Phriction document
Closed	epriestley	D19105 Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email