Page MenuHomePhabricator

Give Phriction documents modern string status constants instead of numeric constants
ClosedPublic

Authored by epriestley on Feb 15 2018, 8:56 PM.

Details

Summary

Depends on D19099. Ref T13077. Updates Phriction documents to string constants to make API interactions cleaner and statuses more practical to extend.

This does not seem to require any transaction migrations because none of the Phriction transactions actually store status values: status is always a side effect of other edits.

Test Plan

Created, edited, deleted, moved documents. Saw appropriate UI cues. Browsed and filtered documents by status in the index.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 15 2018, 8:56 PM
epriestley requested review of this revision.Feb 15 2018, 8:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 2:23 AM
This revision was automatically updated to reflect the committed changes.