Differential D19618

Remove some unusual UI policy hints in Phriction
ClosedPublic
Actions

Authored by epriestley on Aug 28 2018, 10:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 14, 9:00 PM

	Unknown Object (File)
	Sat, Sep 14, 7:57 AM

	Unknown Object (File)
	Fri, Sep 6, 3:44 AM

	Unknown Object (File)
	Fri, Sep 6, 3:44 AM

	Unknown Object (File)
	Fri, Sep 6, 3:44 AM

	Unknown Object (File)
	Mon, Sep 2, 8:27 PM

	Unknown Object (File)
	Mon, Sep 2, 7:36 AM

	Unknown Object (File)
	Sat, Aug 31, 4:57 AM

View All 94 Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13077: Plans: Phriction modern "v3" APIs, Drafts

Commits

rP04f8270a7466: Remove some unusual UI policy hints in Phriction

Summary

Ref T13077. We currently have these weird policy hints in Phriction that we don't use in other applications. Just remove them for consistency to make the eventual swap to EditEngine a little easier.

Also nuke some unreacahble code.

Test Plan

Loaded edit page, saw more standard UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 28 2018, 10:14 PM

Harbormaster completed remote builds in B20702: Diff 46897.Aug 28 2018, 10:16 PM

epriestley requested review of this revision.Aug 28 2018, 10:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2018, 2:32 PM

Closed by commit rP04f8270a7466: Remove some unusual UI policy hints in Phriction (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionEditController.php

24 lines

view/

form/

control/

AphrontFormPolicyControl.php

10 lines

Diff 46898

View Options

src/applications/phriction/controller/PhrictionEditController.php