Page MenuHomePhabricator

Store Phriction max version on Document, improve editing rules for editing documents with drafts
ClosedPublic

Authored by epriestley on Aug 30 2018, 5:09 PM.
Tags
None
Referenced Files
F19082842: D19625.diff
Dec 2 2025, 12:26 PM
F19012623: D19625.id46912.diff
Nov 22 2025, 1:30 PM
F18897156: D19625.id46912.diff
Nov 7 2025, 4:52 PM
F18857002: D19625.diff
Nov 1 2025, 12:36 PM
F18837044: D19625.id46912.diff
Oct 27 2025, 4:12 AM
F18837043: D19625.id46911.diff
Oct 27 2025, 4:12 AM
F18837042: D19625.id.diff
Oct 27 2025, 4:12 AM
F18833956: D19625.diff
Oct 26 2025, 6:48 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13077. We need to know the maximum version of a document in several cases, so denormalize it onto the Document object.

Then clean up some behaviors where we edit a document with, e.g., 7 versions but version 5 is currently published. For now, we: edit starting with version 7, save as version 8, and immediately publish the new version.

Test Plan
  • Ran migration.
  • Edited a draft page without hitting any weird version errors.
  • Checked database for sensible maxVersion values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 30 2018, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.