Page MenuHomePhabricator

Store Phriction max version on Document, improve editing rules for editing documents with drafts
ClosedPublic

Authored by epriestley on Aug 30 2018, 5:09 PM.
Tags
None
Referenced Files
F18194168: D19625.id.diff
Sun, Aug 17, 8:53 AM
F18183717: D19625.diff
Sat, Aug 16, 12:12 PM
F18099321: D19625.diff
Sat, Aug 9, 3:45 AM
Unknown Object (File)
May 19 2025, 8:00 PM
Unknown Object (File)
May 6 2025, 1:06 AM
Unknown Object (File)
Apr 28 2025, 6:11 AM
Unknown Object (File)
Apr 22 2025, 2:31 PM
Unknown Object (File)
Apr 20 2025, 6:00 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13077. We need to know the maximum version of a document in several cases, so denormalize it onto the Document object.

Then clean up some behaviors where we edit a document with, e.g., 7 versions but version 5 is currently published. For now, we: edit starting with version 7, save as version 8, and immediately publish the new version.

Test Plan
  • Ran migration.
  • Edited a draft page without hitting any weird version errors.
  • Checked database for sensible maxVersion values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 30 2018, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.