Page MenuHomePhabricator

Store Phriction max version on Document, improve editing rules for editing documents with drafts
ClosedPublic

Authored by epriestley on Aug 30 2018, 5:09 PM.
Tags
None
Referenced Files
F15465937: D19625.id46912.diff
Thu, Apr 3, 12:23 AM
F15461665: D19625.id.diff
Tue, Apr 1, 10:06 AM
F15459571: D19625.diff
Mon, Mar 31, 2:16 PM
F15429771: D19625.id46911.diff
Mon, Mar 24, 4:13 AM
F15425266: D19625.diff
Sun, Mar 23, 3:39 AM
F15340458: D19625.id46911.diff
Mar 9 2025, 3:15 PM
Unknown Object (File)
Feb 25 2025, 9:26 AM
Unknown Object (File)
Feb 23 2025, 2:13 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13077. We need to know the maximum version of a document in several cases, so denormalize it onto the Document object.

Then clean up some behaviors where we edit a document with, e.g., 7 versions but version 5 is currently published. For now, we: edit starting with version 7, save as version 8, and immediately publish the new version.

Test Plan
  • Ran migration.
  • Edited a draft page without hitting any weird version errors.
  • Checked database for sensible maxVersion values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 30 2018, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.