Page MenuHomePhabricator

Support (basic) commenting on Phriction documents
ClosedPublic

Authored by epriestley on Sep 11 2018, 3:40 PM.
Tags
None
Referenced Files
F19091149: D19660.id.diff
Dec 3 2025, 1:47 PM
F19081519: D19660.diff
Dec 2 2025, 7:08 AM
F18938047: D19660.id46998.diff
Nov 11 2025, 1:48 AM
F18868414: D19660.id46998.diff
Nov 4 2025, 6:31 AM
F18860940: D19660.id.diff
Nov 2 2025, 1:47 PM
F18855918: D19660.diff
Nov 1 2025, 7:19 AM
F18832475: D19660.id46998.diff
Oct 25 2025, 9:57 PM
F18832474: D19660.id46980.diff
Oct 25 2025, 9:57 PM
Subscribers
None

Details

Summary

Depends on D19659. Fixes T1894. Ref T13077. See PHI840.

  • Add an EditEngine, although it currently supports no fields.
  • Add (basic, top-level-only) commenting (we already had the table in the database).

This will probably create some issues. I'm most concerned about documents accumulating a ton of old, irrelevant comments over time which are hard to keep track of and no longer relevant. But I think this is probably a step forward in almost all cases, and a good thing on the balance.

This also moves us incrementally toward putting all editing on top of EditEngine.

Test Plan

Screen Shot 2018-09-11 at 8.35.27 AM.png (1×2 px, 169 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable