Page MenuHomePhabricator

Support (basic) commenting on Phriction documents
ClosedPublic

Authored by epriestley on Sep 11 2018, 3:40 PM.
Tags
None
Referenced Files
F15453896: D19660.diff
Sat, Mar 29, 2:56 PM
F15440544: D19660.id46980.diff
Wed, Mar 26, 1:19 PM
F15439873: D19660.id46998.diff
Wed, Mar 26, 9:58 AM
F15436633: D19660.id.diff
Tue, Mar 25, 3:35 PM
F15430665: D19660.diff
Mon, Mar 24, 8:31 AM
F15425061: D19660.id46998.diff
Sun, Mar 23, 2:18 AM
F15415320: D19660.diff
Thu, Mar 20, 5:24 AM
Unknown Object (File)
Feb 21 2025, 11:27 AM
Subscribers
None

Details

Summary

Depends on D19659. Fixes T1894. Ref T13077. See PHI840.

  • Add an EditEngine, although it currently supports no fields.
  • Add (basic, top-level-only) commenting (we already had the table in the database).

This will probably create some issues. I'm most concerned about documents accumulating a ton of old, irrelevant comments over time which are hard to keep track of and no longer relevant. But I think this is probably a step forward in almost all cases, and a good thing on the balance.

This also moves us incrementally toward putting all editing on top of EditEngine.

Test Plan

Screen Shot 2018-09-11 at 8.35.27 AM.png (1×2 px, 169 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable