Page MenuHomePhabricator

Support (basic) commenting on Phriction documents
ClosedPublic

Authored by epriestley on Sep 11 2018, 3:40 PM.

Details

Summary

Depends on D19659. Fixes T1894. Ref T13077. See PHI840.

  • Add an EditEngine, although it currently supports no fields.
  • Add (basic, top-level-only) commenting (we already had the table in the database).

This will probably create some issues. I'm most concerned about documents accumulating a ton of old, irrelevant comments over time which are hard to keep track of and no longer relevant. But I think this is probably a step forward in almost all cases, and a good thing on the balance.

This also moves us incrementally toward putting all editing on top of EditEngine.

Test Plan

Screen Shot 2018-09-11 at 8.35.27 AM.png (1×2 px, 169 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable