HomePhabricator

Specify a null behavior for the callsign sort column.

Description

Specify a null behavior for the callsign sort column.

Summary:
Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for null on the OderableColumns definition for the callsign column.

See https://phabricator.wikimedia.org/T180457

Test Plan:

  1. On an instance with more than 100 repositories
    • some of which are missing a callsign
  2. Attempt to sort by callsign.
  3. See the sorted results

Previously:

  1. Exception: "Column "0" has null value, but does not specify a null behavior."

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D18773

Details

Provenance
20after4Authored on Nov 14 2017, 11:03 PM
20after4Pushed on Nov 14 2017, 11:16 PM
Reviewer
Blessed Reviewers
Differential Revision
D18773: Specify a null behavior for the callsign sort column.
Parents
rP95a5b41b0ba2: Allow "arc diff --draft" to create revisions as drafts more forcefully
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18831
Build 25382: Run Core Tests