Differential D20208

Support an "authorPHIDs" constraint for "transaction.search"
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 1:02 PM.

Tags

None

Referenced Files

	F15470924: D20208.diff
	Sat, Apr 5, 2:10 AM

	F15464816: D20208.id48249.diff
	Wed, Apr 2, 12:51 PM

	F15444861: D20208.diff
	Thu, Mar 27, 11:38 AM

	F15436849: D20208.id48249.diff
	Tue, Mar 25, 4:40 PM

	F15435691: D20208.id48249.diff
	Tue, Mar 25, 9:45 AM

	F15427549: D20208.diff
	Sun, Mar 23, 2:52 PM

	F15420656: D20208.id48249.diff
	Fri, Mar 21, 3:53 PM

	F15417699: D20208.id48249.diff
	Thu, Mar 20, 5:55 PM

View All Files

Subscribers

None

Tokens

"Mountain of Wealth" token, awarded by 20after4.

Details

Reviewers

amckinley

Maniphest Tasks

T13255: transaction.search should accept user PHIDs as constraints

Commits

rP767afd1780fd: Support an "authorPHIDs" constraint for "transaction.search"

Summary

Ref T13255. The "transaction.search" API method currently does not support author constraints, but this is a reasonable thing to support.

Test Plan

Queried transactions by author, hit the error cases.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 25 2019, 1:02 PM

Harbormaster completed remote builds in B22110: Diff 48249.Feb 25 2019, 1:04 PM

epriestley requested review of this revision.Feb 25 2019, 1:04 PM

amckinley accepted this revision.Feb 25 2019, 1:27 PM

This revision is now accepted and ready to land.Feb 25 2019, 1:27 PM

epriestley added a child revision: D20209: Enrich the "change project tags" transaction in "transaction.search".Feb 25 2019, 1:35 PM

20after4 awarded a token.Feb 25 2019, 1:52 PM

Closed by commit rP767afd1780fd: Support an "authorPHIDs" constraint for "transaction.search" (authored by epriestley). · Explain WhyFeb 25 2019, 2:33 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13255: transaction.search should accept user PHIDs as constraints.Feb 25 2019, 7:08 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

59 lines

Diff 48253

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Support an "authorPHIDs" constraint for "transaction.search"ClosedPublicActions