Page MenuHomePhabricator

Specify a null behavior for the callsign sort column.
ClosedPublic

Authored by 20after4 on Nov 14 2017, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 7:43 AM
Unknown Object (File)
Thu, Dec 12, 12:59 PM
Unknown Object (File)
Sat, Dec 7, 12:57 PM
Unknown Object (File)
Thu, Dec 5, 2:20 AM
Unknown Object (File)
Sun, Dec 1, 3:48 PM
Unknown Object (File)
Wed, Nov 27, 11:01 PM
Unknown Object (File)
Tue, Nov 26, 10:44 AM
Unknown Object (File)
Sun, Nov 24, 12:52 AM
Subscribers

Details

Summary

Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for null on the OderableColumns definition for the callsign column.

See https://phabricator.wikimedia.org/T180457

Test Plan
  1. On an instance with more than 100 repositories
    • some of which are missing a callsign
  2. Attempt to sort by callsign.
  3. See the sorted results

Previously:

  1. Exception: "Column "0" has null value, but does not specify a null behavior."

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable