Page MenuHomePhabricator
Feed All Stories

Feb 24 2020

epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21028: Read both email addresses and Google Account IDs from Google OAuth.
Feb 24 2020, 9:23 PM · Auth
epriestley added a comment to T5591: Add default domain to Google auth.

As of early 2020, this change works:

Feb 24 2020, 9:20 PM · Restricted Project, Restricted Project, Auth
epriestley closed T4289: JIRA authenticator JIRA version 5 compatibility, a subtask of T5422: Does Phabricator integrate with JIRA?, as Wontfix.
Feb 24 2020, 9:10 PM · Guides, Doorkeeper
epriestley closed T4289: JIRA authenticator JIRA version 5 compatibility as Wontfix.

JIRA did this (changed how accounts are identified) again recently (key is now accountId), see T13493.

Feb 24 2020, 9:10 PM · Auth
epriestley added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

One minor issue with this is that there's some duplication when the commit Fixes Txxx and the associated revision already has the edge (which is very common if the commit Fixes Txxx, because the revision almost always also Fixes Txxx):

Feb 24 2020, 9:00 PM · Maniphest, Differential, Diffusion
epriestley committed rP785f3c98da3a: Extract raw commit messages from Git more faithfully across Git versions (authored by epriestley).
Extract raw commit messages from Git more faithfully across Git versions
Feb 24 2020, 8:37 PM
epriestley closed T5028: Commit message text formatting in remote git repository (SSH) is not preserved as Resolved by committing rP785f3c98da3a: Extract raw commit messages from Git more faithfully across Git versions.
Feb 24 2020, 8:37 PM · Diffusion
epriestley closed D21027: Extract raw commit messages from Git more faithfully across Git versions.
Feb 24 2020, 8:37 PM
epriestley added a comment to T5028: Commit message text formatting in remote git repository (SSH) is not preserved.

To follow up on this:

Feb 24 2020, 7:53 PM · Diffusion
epriestley requested review of D21027: Extract raw commit messages from Git more faithfully across Git versions.
Feb 24 2020, 7:48 PM
epriestley added a revision to T5028: Commit message text formatting in remote git repository (SSH) is not preserved: D21027: Extract raw commit messages from Git more faithfully across Git versions.
Feb 24 2020, 7:47 PM · Diffusion
epriestley added a comment to T5028: Commit message text formatting in remote git repository (SSH) is not preserved.

I can't find any changelog in any version of Git which mentions the introduction of %B. The %B behavior was introduced in this commit in March, 2010:

Feb 24 2020, 7:21 PM · Diffusion
epriestley added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

See also PHI1605 (internal), which provides some evidence that:

Feb 24 2020, 5:05 PM · Guides, Harbormaster
epriestley committed rPd3f4af4a3a0b: Add more layout constraints to tokenizer CSS to prevent layout issues with… (authored by epriestley).
Add more layout constraints to tokenizer CSS to prevent layout issues with…
Feb 24 2020, 4:00 PM
epriestley closed T13495: In Firefox 73 and some other browser at non-100% zoom levels, Chinese glyphs cause tokenizer tokens to take up too much vertical space as Resolved by committing rPd3f4af4a3a0b: Add more layout constraints to tokenizer CSS to prevent layout issues with….
Feb 24 2020, 4:00 PM · Design
epriestley closed D21026: Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73.
Feb 24 2020, 4:00 PM
epriestley requested review of D21026: Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73.
Feb 24 2020, 3:48 PM
epriestley added a revision to T13495: In Firefox 73 and some other browser at non-100% zoom levels, Chinese glyphs cause tokenizer tokens to take up too much vertical space: D21026: Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73.
Feb 24 2020, 3:47 PM · Design
epriestley claimed T13495: In Firefox 73 and some other browser at non-100% zoom levels, Chinese glyphs cause tokenizer tokens to take up too much vertical space.
Feb 24 2020, 3:30 PM · Design
epriestley triaged T13495: In Firefox 73 and some other browser at non-100% zoom levels, Chinese glyphs cause tokenizer tokens to take up too much vertical space as Wishlist priority.
Feb 24 2020, 3:30 PM · Design

Feb 23 2020

solarnz added inline comments to rARC9cd72baae92c: Update Phage for toolsets and restore library loading behaviors.
Feb 23 2020, 10:53 PM
epriestley committed rARC9cd72baae92c: Update Phage for toolsets and restore library loading behaviors (authored by epriestley).
Update Phage for toolsets and restore library loading behaviors
Feb 23 2020, 5:31 PM
epriestley closed D21025: Update Phage for toolsets and restore library loading behaviors.
Feb 23 2020, 5:31 PM
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: D21025: Update Phage for toolsets and restore library loading behaviors.
Feb 23 2020, 5:30 PM · Arcanist
epriestley committed rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse (authored by epriestley).
Fix two "implode()" order issues arising from wilds/experimental collapse
Feb 23 2020, 4:34 PM
epriestley closed D21024: Fix two "implode()" order issues arising from wilds/experimental collapse.
Feb 23 2020, 4:34 PM
epriestley requested review of D21024: Fix two "implode()" order issues arising from wilds/experimental collapse.
Feb 23 2020, 4:33 PM
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: D21024: Fix two "implode()" order issues arising from wilds/experimental collapse.
Feb 23 2020, 4:33 PM · Arcanist
epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

I landed everything so far to master. The new behavior in master should be:

Feb 23 2020, 2:01 AM · Auth
epriestley committed rPe58ef418c798: Read both older "key" and newer "accountId" identifiers from JIRA during… (authored by epriestley).
Read both older "key" and newer "accountId" identifiers from JIRA during…
Feb 23 2020, 1:49 AM
epriestley closed D21023: Read both older "key" and newer "accountId" identifiers from JIRA during authentication.
Feb 23 2020, 1:49 AM
epriestley committed rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount" (authored by epriestley).
Remove all readers and writers of "accountID" on "ExternalAccount"
Feb 23 2020, 1:49 AM
epriestley closed D21022: Remove all readers and writers of "accountID" on "ExternalAccount".
Feb 23 2020, 1:49 AM
epriestley committed rP84b5ad09e6e2: Remove all readers and all nontrivial writers for "accountType" and… (authored by epriestley).
Remove all readers and all nontrivial writers for "accountType" and…
Feb 23 2020, 1:48 AM
epriestley closed D21019: Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount".
Feb 23 2020, 1:48 AM
epriestley committed rPb8f0613b30dd: Update Asana feed publishing integration for "ExternalAccountIdentifier" (authored by epriestley).
Update Asana feed publishing integration for "ExternalAccountIdentifier"
Feb 23 2020, 1:48 AM
epriestley closed D21018: Update Asana feed publishing integration for "ExternalAccountIdentifier".
Feb 23 2020, 1:48 AM
epriestley committed rPfaf9f06e0a71: Migrate all "accountID" values to "ExternalAccountIdentifier" objects (authored by epriestley).
Migrate all "accountID" values to "ExternalAccountIdentifier" objects
Feb 23 2020, 1:47 AM
epriestley closed D21017: Migrate all "accountID" values to "ExternalAccountIdentifier" objects.
Feb 23 2020, 1:47 AM
epriestley committed rPbcaf60015a47: Write ExternalAccountIdentifiers when interacting with external authentication… (authored by epriestley).
Write ExternalAccountIdentifiers when interacting with external authentication…
Feb 23 2020, 1:47 AM
epriestley closed D21016: Write ExternalAccountIdentifiers when interacting with external authentication providers.
Feb 23 2020, 1:46 AM
epriestley committed rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all… (authored by epriestley).
Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Feb 23 2020, 1:46 AM
epriestley closed D21015: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible.
Feb 23 2020, 1:46 AM
epriestley committed rP05eb16d6de51: Update unusual handling of external accounts in "Password" auth provider (authored by epriestley).
Update unusual handling of external accounts in "Password" auth provider
Feb 23 2020, 1:46 AM
epriestley closed D21014: Update unusual handling of external accounts in "Password" auth provider.
Feb 23 2020, 1:46 AM
epriestley committed rPe43ecad8afc4: Make external account identifier APIs return multiple identifiers (authored by epriestley).
Make external account identifier APIs return multiple identifiers
Feb 23 2020, 1:45 AM
epriestley closed D21013: Make external account identifier APIs return multiple identifiers.
Feb 23 2020, 1:45 AM
epriestley committed rP40946248280e: Remove an ancient no-op check for duplicated external accounts (authored by epriestley).
Remove an ancient no-op check for duplicated external accounts
Feb 23 2020, 1:45 AM
epriestley closed D21012: Remove an ancient no-op check for duplicated external accounts.
Feb 23 2020, 1:45 AM
epriestley committed rP70845a2d13fc: Add an "ExternalAccountIdentifier" table (authored by epriestley).
Add an "ExternalAccountIdentifier" table
Feb 23 2020, 1:44 AM
epriestley closed D21011: Add an "ExternalAccountIdentifier" table.
Feb 23 2020, 1:44 AM
epriestley committed rPfbf050167e25: Stop exposing raw "accountID" values directly in the web UI (authored by epriestley).
Stop exposing raw "accountID" values directly in the web UI
Feb 23 2020, 1:42 AM
epriestley closed D21010: Stop exposing raw "accountID" values directly in the web UI.
Feb 23 2020, 1:42 AM
epriestley requested review of D21023: Read both older "key" and newer "accountId" identifiers from JIRA during authentication.
Feb 23 2020, 1:37 AM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21023: Read both older "key" and newer "accountId" identifiers from JIRA during authentication.
Feb 23 2020, 1:36 AM · Auth
epriestley updated the diff for D21016: Write ExternalAccountIdentifiers when interacting with external authentication providers.
  • Also remove "realName" when unlinking an account.
Feb 23 2020, 1:30 AM
epriestley requested review of D21022: Remove all readers and writers of "accountID" on "ExternalAccount".
Feb 23 2020, 1:21 AM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21022: Remove all readers and writers of "accountID" on "ExternalAccount".
Feb 23 2020, 1:20 AM · Auth
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": Unknown Object (Differential Revision).
Feb 23 2020, 1:17 AM · Auth
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Feb 23 2020, 1:16 AM · Arcanist
epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

I stumbled across what appears to be a very mild security issue in JIRA that impacts this flow. I've reported it to Atlassian's bug bounty program here (this link may or may not be visible to anyone else):

Feb 23 2020, 12:45 AM · Auth

Feb 22 2020

epriestley requested review of D21019: Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount".
Feb 22 2020, 10:31 PM
epriestley added a revision to T6703: Allow multiple copies of the same auth provider type: D21019: Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount".
Feb 22 2020, 10:30 PM · Auth
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21019: Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount".
Feb 22 2020, 10:30 PM · Auth
epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

This change sequence is almost ready to remove readers and writers to accountID, but there's still a unique <accountType, accountDomain, accountID> key on the table. Removing accountID writers completely will mean that the second user to link an account of a particular type (say, an Asana account) will run into a unique key error (since they'll write a second "Asana" account with the same empty accountID as the first "Asana" account).

Feb 22 2020, 8:54 PM · Auth
epriestley requested review of D21018: Update Asana feed publishing integration for "ExternalAccountIdentifier".
Feb 22 2020, 6:29 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21018: Update Asana feed publishing integration for "ExternalAccountIdentifier".
Feb 22 2020, 6:28 PM · Auth
epriestley requested review of D21017: Migrate all "accountID" values to "ExternalAccountIdentifier" objects.
Feb 22 2020, 4:58 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21017: Migrate all "accountID" values to "ExternalAccountIdentifier" objects.
Feb 22 2020, 4:56 PM · Auth
epriestley updated the diff for D21013: Make external account identifier APIs return multiple identifiers.
  • Fix a logic bug in the OAuth2 provider.
Feb 22 2020, 4:45 PM
epriestley triaged T13494: Feed stories which summarize a transaction list with a user comment and a Herald comment may show both comments as Wishlist priority.
Feb 22 2020, 4:41 PM · Feed
epriestley requested review of D21016: Write ExternalAccountIdentifiers when interacting with external authentication providers.
Feb 22 2020, 4:31 PM
epriestley requested review of D21015: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible.
Feb 22 2020, 3:20 AM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21015: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible.
Feb 22 2020, 3:19 AM · Auth

Feb 21 2020

epriestley requested review of D21014: Update unusual handling of external accounts in "Password" auth provider.
Feb 21 2020, 3:57 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21014: Update unusual handling of external accounts in "Password" auth provider.
Feb 21 2020, 3:54 PM · Auth
epriestley requested review of D21013: Make external account identifier APIs return multiple identifiers.
Feb 21 2020, 3:24 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21013: Make external account identifier APIs return multiple identifiers.
Feb 21 2020, 3:23 PM · Auth
epriestley requested review of D21012: Remove an ancient no-op check for duplicated external accounts.
Feb 21 2020, 12:12 AM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21012: Remove an ancient no-op check for duplicated external accounts.
Feb 21 2020, 12:11 AM · Auth
epriestley updated the task description for T13491: Why does Arcanist require "--"?.
Feb 21 2020, 12:10 AM · Guides
epriestley updated the task description for T13491: Why does Arcanist require "--"?.
Feb 21 2020, 12:10 AM · Guides
epriestley updated the task description for T13491: Why does Arcanist require "--"?.
Feb 21 2020, 12:09 AM · Guides

Feb 20 2020

20after4 awarded T13491: Why does Arcanist require "--"? a Burninate token.
Feb 20 2020, 11:48 PM · Guides
epriestley requested review of D21011: Add an "ExternalAccountIdentifier" table.
Feb 20 2020, 10:22 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21011: Add an "ExternalAccountIdentifier" table.
Feb 20 2020, 10:21 PM · Auth
epriestley added a comment to T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading.

In T13493, PhabricatorExternalAccountIdentifier could also benefit from this null policy behavior.

Feb 20 2020, 9:41 PM · Policy
epriestley requested review of D21010: Stop exposing raw "accountID" values directly in the web UI.
Feb 20 2020, 9:34 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21010: Stop exposing raw "accountID" values directly in the web UI.
Feb 20 2020, 9:33 PM · Auth
epriestley committed rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley).
Whitelist "vscode://" as an allowed Editor protocol
Feb 20 2020, 8:45 PM
epriestley closed D21009: Whitelist "vscode://" as an allowed Editor protocol.
Feb 20 2020, 8:45 PM
epriestley requested review of D21009: Whitelist "vscode://" as an allowed Editor protocol.
Feb 20 2020, 8:43 PM
epriestley committed rP29923cc71a46: Remove old code for sending email to external users who create objects via… (authored by epriestley).
Remove old code for sending email to external users who create objects via…
Feb 20 2020, 8:42 PM
epriestley closed D21007: Remove old code for sending email to external users who create objects via inbound mail.
Feb 20 2020, 8:41 PM
epriestley requested review of D21007: Remove old code for sending email to external users who create objects via inbound mail.
Feb 20 2020, 8:30 PM
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": D21007: Remove old code for sending email to external users who create objects via inbound mail.
Feb 20 2020, 8:29 PM · Auth
epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

These callers use accountId:

Feb 20 2020, 8:24 PM · Auth
epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

I think the patch above is a piece of the solution here, but makes behavior worse for some installs: installs with a version of JIRA which returns both key and accountId will have worse behavior under the patch than without it (since it will break all the existing account links immediately). It also doesn't smoothly migrate these installs, even though it's theoretically easy/desirable to do that.

Feb 20 2020, 5:43 PM · Auth
epriestley closed T12157: Make it visibly clearer that a Phabricator user account has been disabled as Resolved.

Ah, thanks. Yeah, I think that's reasonable. I'm sure some other things can still be cleaned up -- like I changed the "Subscribers" UI a little bit recently, and it could now handle disabled users more clearly:

Feb 20 2020, 5:27 PM · Profile, Feature Request
aklapper added a comment to T12157: Make it visibly clearer that a Phabricator user account has been disabled.

IMHO this could be closed as resolved these days.

Feb 20 2020, 3:30 PM · Profile, Feature Request