Page MenuHomePhabricator

Remove old code for sending email to external users who create objects via inbound mail
ClosedPublic

Authored by epriestley on Feb 20 2020, 8:29 PM.

Details

Summary

Ref T13493. I'm updating callers to getAccountID() to prepare to move it to a separate table.

This callsite once supported this flow:

  • External users with no accounts send mail to bugs@.
  • This creates tasks in Maniphest.
  • They're CC'd when the tasks are updated.

However, after T12237 we never actually send this mail (since their addresses are necessarily unverified).

I left this code in in case this needed to be revisited, but it hasn't been an issue. Just remove it and treat these users as undeliverable.

Test Plan

As a cursory test for nothing being horribly broken, sent some object mail.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 20 2020, 8:29 PM
epriestley requested review of this revision.Feb 20 2020, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.