Paths

Table of Contentst

" as an allowed Editor protocol
ClosedPublic
Actions

Authored by epriestley on Feb 20 2020, 8:41 PM.

Tags

None

Referenced Files

	F18100892: D21009.diff
	Sat, Aug 9, 12:09 PM

	F18092066: D21009.id50053.diff
	Thu, Aug 7, 4:21 AM

	F18084128: D21009.id.diff
	Tue, Aug 5, 1:50 PM

	F18066931: D21009.diff
	Mon, Aug 4, 2:40 PM

	F18056407: D21009.id50051.diff
	Mon, Aug 4, 8:24 AM

	F17998168: D21009.diff
	Sat, Aug 2, 5:28 AM

	F17854027: D21009.id50053.diff
	Jul 27 2025, 2:35 PM

	F17819782: D21009.diff
	Jul 26 2025, 1:30 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol
rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol

Summary

See PHI1647, which asks for "vscode://" to be a configurable protocol on hosted Phacility instances.

I made the configuration editable in D21008, but this can reasonably just come upstream too.

Test Plan

Viewed config in Config, set my editor URI to vscode://blahblah.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 20 2020, 8:41 PM

Harbormaster completed remote builds in B23875: Diff 50051.Feb 20 2020, 8:43 PM

epriestley requested review of this revision.Feb 20 2020, 8:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:45 PM

Closed by commit rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol.

epriestley added a commit: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol.Apr 5 2020, 4:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

3 lines

Diff 50053

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php

Whitelist "vscode://" as an allowed Editor protocolClosedPublicActions