Page MenuHomePhabricator

Whitelist "vscode://" as an allowed Editor protocol
ClosedPublic

Authored by epriestley on Feb 20 2020, 8:41 PM.

Details

Summary

See PHI1647, which asks for "vscode://" to be a configurable protocol on hosted Phacility instances.

I made the configuration editable in D21008, but this can reasonably just come upstream too.

Test Plan

Viewed config in Config, set my editor URI to vscode://blahblah.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 20 2020, 8:41 PM
epriestley requested review of this revision.Feb 20 2020, 8:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:45 PM
This revision was automatically updated to reflect the committed changes.