Paths

Table of Contentst

" as an allowed Editor protocol
ClosedPublic
Actions

Authored by epriestley on Feb 20 2020, 8:41 PM.

Tags

None

Referenced Files

	F15471343: D21009.id50051.diff
	Sat, Apr 5, 4:37 AM

	F15466424: D21009.id50051.diff
	Thu, Apr 3, 5:22 AM

	F15466258: D21009.id50053.diff
	Thu, Apr 3, 3:33 AM

	F15462266: D21009.id.diff
	Tue, Apr 1, 1:33 PM

	F15459605: D21009.diff
	Mon, Mar 31, 2:30 PM

	F15452804: D21009.diff
	Sat, Mar 29, 7:24 AM

	F15436837: D21009.id50051.diff
	Mar 25 2025, 4:38 PM

	F15432803: D21009.id50051.diff
	Mar 24 2025, 7:40 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol
rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol

Summary

See PHI1647, which asks for "vscode://" to be a configurable protocol on hosted Phacility instances.

I made the configuration editable in D21008, but this can reasonably just come upstream too.

Test Plan

Viewed config in Config, set my editor URI to vscode://blahblah.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 20 2020, 8:41 PM

Harbormaster completed remote builds in B23875: Diff 50051.Feb 20 2020, 8:43 PM

epriestley requested review of this revision.Feb 20 2020, 8:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:45 PM

Closed by commit rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol.

epriestley added a commit: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol.Apr 5 2020, 4:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

3 lines

Diff 50053

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php

Whitelist "vscode://" as an allowed Editor protocolClosedPublicActions