Page MenuHomePhabricator
Create Task
Maniphest T9412

Annotate all the reasons that a user is included on the recipient list for mail
Open, WishlistPublic
Actions

Description

Viewing a message in /mail/ should explain all the reasons each recipient was included on the message.

This is a whole lot of work but the alternative is fishing expeditions through application features.

Original Description

On our private install, I received the following email:

Date: Mon, 14 Sep 2015 11:54:47 +1000
To: josh@mydomain.com
From: "User A" <phabricator@mydomain.com>
Reply-to: T26779+24+5fe0121e81679d52@phabricator.mydomain.com
Subject: [Maniphest] [Updated] T26779: REDACTED
Message-ID: <61a94cf30e6a613af9646d79c4dc7d69@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <maniphest-projects>
Thread-Topic: T26779: REDACTED
X-Herald-Rules: <29>, <26>
X-Phabricator-Projects: <#project_one>, <#project_two>
X-Phabricator-To: <PHID-USER-fplpdm5kzihjdjndb6ql>
X-Phabricator-Cc: <PHID-USER-fplpdm5kzihjdjndb6ql>
X-Phabricator-Cc: <PHID-USER-hff4bjlxuuo5n27uuaat>
X-Phabricator-Cc: <PHID-USER-abzwhc667osh5mwd4gk7>
Precedence: bulk
In-Reply-To: <maniphest-task-PHID-TASK-qkkj25dgcadxcktq4jlb@phabricator.mydomain.com>
References: <maniphest-task-PHID-TASK-qkkj25dgcadxcktq4jlb@phabricator.mydomain.com>
Thread-Index: YTBmMmMzZjVhMDVhYTIzNzRiODhjZjJlNWQyIFX2KOc=
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mydomain.com; 
 i=@mydomain.com; q=dns/txt; s=mail; t=1442195687; h=Subject : To : 
 From : Date; bh=aHov4ld5zVxvkLoXMdJ3Y77H0Gum08xpg6nfguy9m5M=; 
 b=aNyM0PMLUJ7FF6M8Xsb1e5yVanRIhzEoqrQdBkrY6+RRvFMaIHXpeJBIPDqyxg24BWYloT
 rHxk0r7ppDsmSsUdjjeAHJ0/ewdUI4RO0NhwmGxVGhIsurL/GqrN7ujBBpb1NOkWqQjiZ92D
 W3FpsSMQ+bTBp8EDroWkkVj1lA91A=

user_a added a project: #project_one.

TASK DETAIL
https://phabricator.mydomain.com/T26779

EMAIL PREFERENCES
https://phabricator.mydomain.com/settings/panel/emailpreferences/

To: user_a
Cc: user_a, user_b, user_c

When I navigate to the task, however, user_b isn't a subscriber. There are no transactions which act on user_b either.

Related Objects

Event Timeline

joshuaspence created this task.Sep 14 2015, 7:14 AM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Mail.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Sep 14 2015, 11:42 AM

Do Herald rules 26 or 29 send them mail?

joshuaspence added a comment.Sep 14 2015, 11:43 AM

No, both rules are a custom action which notifies a HipChat room.

epriestley added a comment.Sep 14 2015, 11:45 AM

Does user_b watch #project_one or #project_two?

epriestley added a comment.Sep 14 2015, 11:46 AM

(That should be shown in "Watchers" on the project pages.)

joshuaspence added a comment.Sep 14 2015, 11:48 AM

Ah yeah, it seems that is the case.

epriestley added a comment.Sep 14 2015, 11:49 AM

I vaguely intend to rewrite all the code which adds recipients to collect the reasons they were added so it says "user_b (watches #project_one, author, added by Herald, subscribed implicitly by comment)" somewhere. But this is a lot of work.

epriestley renamed this task from Email CC list shows wrong user to Annotate all the reasons that a user is included on the recipient list for mail.Sep 25 2015, 3:29 PM
epriestley triaged this task as Wishlist priority.
epriestley updated the task description. (Show Details)
eadler mentioned this in T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.Apr 15 2016, 3:33 PM
eadler mentioned this in T11019: Improve UX and general awareness of "remote diff" processing.May 23 2016, 10:04 PM
eadler mentioned this in T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.
eadler merged a task: T6297: Maniphest email notification doesn't say why I'm receiving it.Jul 6 2016, 4:27 AM
eadler added subscribers: nemobis, eadler, bbrdaric and 7 others.
chad merged a task: T11282: Clearly indicate in email footer how to unsubscribe from similar emails.Jul 6 2016, 5:37 PM
chad added a subscriber: swisspol.
swisspol added a comment.Jul 7 2016, 6:15 PM

Until this is implemented, can someone tell me how to unsubscribe from Harbor Master build failure emails (see T11282)?

epriestley added a comment.Jul 7 2016, 7:11 PM

There is no way to unsubscribe from them.

epriestley moved this task from Backlog to v3 on the Mail board.Jul 16 2016, 1:47 PM
epriestley mentioned this in T11337: Mail v3.Jul 16 2016, 3:31 PM
eadler added a project: Restricted Project.Jul 25 2016, 4:54 PM
eadler added a project: llvm.Sep 30 2016, 7:07 AM
eadler moved this task from Backlog to Nice To Have on the llvm board.
aklapper added a comment.May 14 2017, 3:47 PM

Another anecdote explaining that the current situation is confusing:
As a user who has not been active in Phabricator for a while and as my interests in projects might have shifted, I am trying to find out why I receive email notifications about certain tasks and how to disable these specific notifications to reduce the amount of uninteresting mail. But:

  • My "Profile" user page does not list any "Projects".
  • The email headers do not tell me either why I received an email.

After some thinking I realized that the reason was that I was a watcher (but not a member) of an associated project tag of a task.
I'd expect my "Profile" user page to not only list "Projects" (actually means: Member) but also projects that I only watch. Currently I need to go to one of the tasks that I received an email about, click all associated projects, and go to the "Members and Watchers" page of each project to find out that I once added myself as a "watcher" and remove myself.
However, that might still not explain why I received a specific email: If I have "Settings > Email > Email Preferences > Maniphest Tasks > One of a task's subtasks changes status" enabled, I also need to check all subtasks' projects whether I watch one of them.

This problem was originally brought up in https://www.mediawiki.org/wiki/Topic:Tpsayrat5314d0j9

chad added a comment.May 14 2017, 3:54 PM

I don't expect watchers to be on profile, but we should provide a search for it in /projects/

chad added a comment.May 14 2017, 4:03 PM

Filed T12707 to follow up.

epriestley mentioned this in T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags.Feb 15 2018, 4:13 PM
hskiba added a subscriber: hskiba.Feb 15 2018, 4:14 PM
Gryllida awarded a token.Mar 9 2018, 12:48 AM
Gryllida added a subscriber: Gryllida.
Phabricator · Built by Phacility