Page MenuHomePhabricator
Feed All Stories

Apr 10 2017

epriestley added a comment to T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations.

See also T12532 for related work.

Apr 10 2017, 10:49 PM · Contributor Onboarding, Bug Report
epriestley added a revision to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0: Unknown Object (Differential Revision).
Apr 10 2017, 10:49 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

I think the first error is causing (maybe?) the chunk engine to fail, so we're falling back to the "upload the entire file in one shot" engine, which ain't great on 4GB files.

Apr 10 2017, 10:44 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Alright, let me take a look. That exception is pretty specific and it may be obvious from the code.

Apr 10 2017, 10:39 PM · Arcanist, Files, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Hmm, I got a different error with a 9MB file. But this looks like a problem on our end:

Apr 10 2017, 10:39 PM · Arcanist, Files, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

I originally tried a 1GB file and wasn't able to reproduce...

Apr 10 2017, 10:38 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

(Actually maybe you need a 9MB file.)

Apr 10 2017, 10:37 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Does this reproduce with a 5MB file?

Apr 10 2017, 10:37 PM · Arcanist, Files, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

From the server-side error logs:

Apr 10 2017, 10:35 PM · Arcanist, Files, Bug Report
joshuaspence added a project to T12532: `syntax.filemap` does not validate input: Config.
Apr 10 2017, 10:33 PM · Contributor Onboarding, Config, Bug Report
joshuaspence created T12532: `syntax.filemap` does not validate input.
Apr 10 2017, 10:33 PM · Contributor Onboarding, Config, Bug Report
jmeador moved T12244: Provide a crude way to selectively disable reads and writes of repository devices by setting flags on Almanac bindings from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 10 2017, 10:33 PM · Restricted Project, Almanac
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Okay, I managed to reproduce it with non-sensitive data:

Apr 10 2017, 10:28 PM · Arcanist, Files, Bug Report
joshuaspence created T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.
Apr 10 2017, 10:21 PM · Arcanist, Files, Bug Report
ivo created T12530: Add UI support for more types of recurring events.
Apr 10 2017, 10:17 PM · Calendar, Feature Request
epriestley moved T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository from Backlog to arc patch on the Arcanist board.
Apr 10 2017, 10:14 PM · Arcanist, Mercurial, Bug Report
epriestley moved T12501: `arc patch` blows up when the revision's parent has already landed from Backlog to arc patch on the Arcanist board.
Apr 10 2017, 10:14 PM · Arcanist, Restricted Project, Bug Report
epriestley added a revision to T12503: Curtain sections may overflow boundaries in the UI: Unknown Object (Differential Revision).
Apr 10 2017, 10:09 PM · PHUI
epriestley closed T12504: Files "Temporary" badge is white-on-grey as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 10:01 PM · Files, PHUI
epriestley added a revision to T12504: Files "Temporary" badge is white-on-grey: Unknown Object (Differential Revision).
Apr 10 2017, 9:57 PM · Files, PHUI
chad closed T12138: Send-on-Enter and Fullscreen Mode interact destructively as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 9:39 PM · Remarkup, Conpherence
epriestley closed T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 9:15 PM · Bug Report
epriestley added a project to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Phacility.

A SAAS install reported bumping into this.

Apr 10 2017, 9:15 PM · Search, Customer Impact, Bug Report
Rtzq0 added a comment to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.

Absolutely. Thanks very much.

Apr 10 2017, 8:06 PM · Bug Report
EddieGP added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

Do you routinely schedule events in timezones other than UTC or your local time?

Apr 10 2017, 7:26 PM · KDE, Calendar, Feature Request
epriestley added a comment to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.

Does the language in D17648 look OK?

Apr 10 2017, 7:23 PM · Bug Report
epriestley added a revision to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow: Unknown Object (Differential Revision).
Apr 10 2017, 7:23 PM · Bug Report
Rtzq0 added a comment to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.

@epriestley would

The second field (which is the password field) must not be set to !!. This value will prevent login. If it is set to !!, run 'usermod -p NP vcs-user' to block only password logins. If usermod is not available on your system you will need to set the password field value for vcs-user to 'NP' by manually editing /etc/shadow.

be acceptable?

Apr 10 2017, 7:22 PM · Bug Report
epriestley added a comment to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.
epriestley@orbital ~ $ usermod
-bash: usermod: command not found
Apr 10 2017, 7:16 PM · Bug Report
epriestley added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

Do you routinely schedule events in timezones other than UTC or your local time? If so, why? (For example, do you frequently travel between two timezones? Do you schedule events on behalf of a team that works in a different, non-UTC timezone?)

Apr 10 2017, 7:15 PM · KDE, Calendar, Feature Request
EddieGP added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

I'm just trying to understand whether this is a common problem that all users of Calendar software routinely experience

Apr 10 2017, 7:06 PM · KDE, Calendar, Feature Request
Rtzq0 created T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.
Apr 10 2017, 6:43 PM · Bug Report
epriestley closed T12528: Can't send confirmation email if two mails are available as Resolved.

The address is verified but the verified flag on your account is not set.

Apr 10 2017, 5:53 PM · Mail, Bug Report
Luke081515.2 created T12528: Can't send confirmation email if two mails are available.
Apr 10 2017, 5:43 PM · Mail, Bug Report
epriestley closed T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns, a subtask of T12101: Phabricator PHP 7 Compatibility, as Resolved.
Apr 10 2017, 5:34 PM · Infrastructure, Guides
epriestley closed T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 5:34 PM · libphutil, Security
jcox added a comment to T9499: Revision repository is not updated when it is changed in the UI.

We've run into this a couple of times. When a user updates a revision through the web UI, the repository field (at /differential/revision/update/{REVID}/) doesn't auto-populate with the revision's repository and people sometimes forget to fill it out. This causes the repository to be stripped from the revision as well.

Apr 10 2017, 5:31 PM · Differential, Conduit
epriestley added a revision to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns: Unknown Object (Differential Revision).
Apr 10 2017, 4:54 PM · libphutil, Security
epriestley added a comment to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.

I think this is, to at least some degree, a legitimate security problem. Consider:

Apr 10 2017, 4:26 PM · libphutil, Security
epriestley closed T12356: Calendar Notification is not respecting my Time Zone Settings as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 3:48 PM · Calendar, Bug Report
epriestley closed T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 3:47 PM · Calendar, Bug Report
epriestley added a parent task for T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns: T12101: Phabricator PHP 7 Compatibility.
Apr 10 2017, 3:46 PM · libphutil, Security
epriestley added a subtask for T12101: Phabricator PHP 7 Compatibility: T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.
Apr 10 2017, 3:46 PM · Infrastructure, Guides
epriestley closed T11561: Write a "Contributor Onboarding" document as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 3:36 PM · Documentation, Contributor Onboarding
epriestley updated the task description for T12525: amckinley's Onboarding.
Apr 10 2017, 3:26 PM · Phacility, Contributor Onboarding
epriestley created Phage (Phacility).
Apr 10 2017, 3:23 PM
epriestley edited the content of Phacility Cluster CLI Tools.
Apr 10 2017, 3:08 PM
epriestley moved T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 2:54 PM · Calendar, Bug Report
epriestley moved T12356: Calendar Notification is not respecting my Time Zone Settings from Backlog to Unprototype (v1) on the Calendar board.
Apr 10 2017, 2:54 PM · Calendar, Bug Report
epriestley added a comment to T12356: Calendar Notification is not respecting my Time Zone Settings.
  • After D17646, event reminder mail should render with timezone information.
  • Additionally, timezone information in this mail and other modern ModularTransactions mail will now render with timezone abbreviations where available: (PDT) instead of (UTC-7), for example.
  • I wasn't able to identify or reproduce any actual bug here. Hopefully the additional information in D17646 will make it clear what's happening. The expectation is that the mail you receive should use the same locale as your account uses in Settings → Date and Time → Timezone, and in all my local attempts to reproduce this that was the case. Note that if an event is scheduled in UTC but instances cross daylight savings time in a particular locale the local time of the event may change. I don't think that's what happened here, just mentioning it. See also T11073.
Apr 10 2017, 2:54 PM · Calendar, Bug Report
epriestley added a revision to T12356: Calendar Notification is not respecting my Time Zone Settings: Unknown Object (Differential Revision).
Apr 10 2017, 2:48 PM · Calendar, Bug Report
epriestley created T12527: Calendar notifications for recurring events are only sent if you accept invites to every instance.
Apr 10 2017, 2:19 PM · Calendar
epriestley added a comment to T12356: Calendar Notification is not respecting my Time Zone Settings.

I think this is a legitimate bug where the viewer's timezone on the event becomes stuck as the last invitee we process, so events with multiple invitees in different timezones can generate mail with the last user's timezone.

Apr 10 2017, 2:03 PM · Calendar, Bug Report
ollehar added a comment to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured.

I still had this problem, in a fresh install. Had to run

Apr 10 2017, 1:59 PM · Daemons, Diffusion
chad added a comment to T6400: Option to disable Phabricator comment hiding/collapsing.

Then please fork Phabricator to provide this option on your local install. One interested party every few years isn't enough interest for us to add an option, and it's probably 1-2 lines of code for you to provide it for yourself.

Apr 10 2017, 1:57 PM · Maniphest, Wikimedia
epriestley added a comment to T12295: Allow commenting on imported calendar events.

Go ahead and create a new request -- knowing which things people actually want/use will be helpful since other calendaring applications seem to have very complex controls here without much consistency and with different supported sets of capabilities.

Apr 10 2017, 1:46 PM · Calendar, Feature Request
ivo added a comment to T12295: Allow commenting on imported calendar events.

Fair enough. I think that if "on the $nth $weekday of the month" and "on $weekday every $x weeks" were to be supported, we would technically be able to schedule all events in Calendar. Do you know if support for this already planned somewhere, or should I create a new feature request?

Apr 10 2017, 1:42 PM · Calendar, Feature Request
epriestley renamed T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export from Export ICS Exception to Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.
Apr 10 2017, 1:36 PM · Calendar, Bug Report
epriestley moved T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export from Backlog to Unprototype (v1) on the Calendar board.
Apr 10 2017, 1:35 PM · Calendar, Bug Report
epriestley closed T11816: Calendar: Feedback and Suggestions as Resolved.

Future instances of recurring events aren't visible in panels when an item limit is set:

Apr 10 2017, 1:35 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Apr 10 2017, 1:33 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Apr 10 2017, 1:28 PM · Restricted Project, Calendar
epriestley created T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.
Apr 10 2017, 1:26 PM · libphutil, Security
epriestley added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

I'm just trying to understand whether this is a common problem that all users of Calendar software routinely experience, or a problem that is experienced much more strongly at WMF that by most other users.

Apr 10 2017, 12:39 PM · KDE, Calendar, Feature Request
EddieGP added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

How do you currently schedule an event in UTC in other software?
I can't figure out how using Google Calendar -- I can't find any option in this dropdown which let me, but maybe I'm just overlooking it? There are approximately 9 million options. I looked for "International", "UTC", etc.

Screen Shot 2017-04-10 at 4.07.58 AM.png (1×554 px, 156 KB)

Apr 10 2017, 12:25 PM · KDE, Calendar, Feature Request
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Apr 10 2017, 11:58 AM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

This is her status at 13:45 today...
She doesn't have any events till 14:00 today.

Apr 10 2017, 11:45 AM · Restricted Project, Calendar
epriestley added a revision to T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export: Unknown Object (Differential Revision).
Apr 10 2017, 11:37 AM · Calendar, Bug Report
epriestley added a comment to T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.

I believe this occurs only if an install has improperly migrated legacy data. This install does; presumably yours does as well.

Apr 10 2017, 11:33 AM · Calendar, Bug Report
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

@ivo, I'll follow up for this on T12488 which appears to be a similar standalone report:

Apr 10 2017, 11:20 AM · Restricted Project, Calendar
epriestley moved T11073: Allow the user to specify a date in a different timezone using date controls from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 11:16 AM · KDE, Calendar, Feature Request
epriestley added a project to T11073: Allow the user to specify a date in a different timezone using date controls: Calendar.
Apr 10 2017, 11:15 AM · KDE, Calendar, Feature Request
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

@EddieGP, see T11073.

Apr 10 2017, 11:15 AM · Restricted Project, Calendar
epriestley closed T11801: Calendar: ICS Import Errata as Resolved.

ICS issues seem to have calmed down so I'm going to call this resolved; future issues can just be filed as separate tasks.

Apr 10 2017, 11:05 AM · Bug Report, Calendar
epriestley triaged T11399: Add support for locations in calendar events as Wishlist priority.
Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley moved T12295: Allow commenting on imported calendar events from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley triaged T12295: Allow commenting on imported calendar events as Wishlist priority.

This is technically possible (and I believe imported events do have some support for mutation within Phabricator today: for example, I believe you can award them tokens). However, I'm very hesitant to start making imported events writable.

Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley added a subtask for T12295: Allow commenting on imported calendar events: T11800: When duplicate events are imported into Calendar, show viewers only the best version.
Apr 10 2017, 10:58 AM · Calendar, Feature Request
epriestley added a parent task for T11800: When duplicate events are imported into Calendar, show viewers only the best version: T12295: Allow commenting on imported calendar events.
Apr 10 2017, 10:58 AM · Calendar
nmcalabroso awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Burninate token.
Apr 10 2017, 10:23 AM · Lint, Arcanist
xuri added a comment to T11921: Set mail sender name as "<User> via <Configurable name>"..

Set mail sender as custom name to edit file externals/phpmailer/class.phpmailer.php, change $this->FromName = $name; to $this->FromName = 'CodeReview';.

Apr 10 2017, 8:14 AM · Feature Request
Maaaks added a comment to T6400: Option to disable Phabricator comment hiding/collapsing.

I disagree. This option is a lot like email notification options which are already present in Phabricator. It expresses very personal preferences of how user prefers to read the same content. And for me it is more important than ability to set board backgrounds.

Apr 10 2017, 6:48 AM · Maniphest, Wikimedia
avivey awarded T12525: amckinley's Onboarding a Party Time token.
Apr 10 2017, 5:21 AM · Phacility, Contributor Onboarding
chad added a comment to T6400: Option to disable Phabricator comment hiding/collapsing.

See T8227: Why not just add an option/setting/preference?

Apr 10 2017, 5:18 AM · Maniphest, Wikimedia
Maaaks added a comment to T6400: Option to disable Phabricator comment hiding/collapsing.

Hello, here is my use case.

Apr 10 2017, 1:45 AM · Maniphest, Wikimedia

Apr 9 2017

• tomekj2ee awarded T3569: Make Phrequent somewhat usable a Like token.
Apr 9 2017, 10:07 PM · Phrequent
• tomekj2ee awarded T6411: Countdown Panel a Like token.
Apr 9 2017, 9:03 PM · Countdown
chad edited projects for T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository, added: Bug Report (Needs Information); removed Bug Report.

This still needs complete reproduction steps to be accepted into the upstream. My suggestion is find another VM and load out what you expect the issue is with, and give us those details. Right now it sounds like you're just guessing and that's outside of what we expect when following Contributing Bug Reports. See https://secure.phabricator.com/book/phabcontrib/article/reproduction_steps/ if you need more guidance on providing these steps.

Apr 9 2017, 6:27 PM · Bug Report (Needs Information)
• tomekj2ee awarded T4213: Provide custom themes, skinning, or custom CSS a Love token.
Apr 9 2017, 4:39 PM · Design
rafaelrabeloit added a comment to T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.
In T12521#218608, @chad wrote:

Does this reproduce against a Phacility instance or our test mercurial repository here?

Apr 9 2017, 2:31 PM · Bug Report (Needs Information)
epriestley created T12525: amckinley's Onboarding.
Apr 9 2017, 1:46 PM · Phacility, Contributor Onboarding
epriestley added a revision to T11561: Write a "Contributor Onboarding" document: Unknown Object (Differential Revision).
Apr 9 2017, 11:58 AM · Documentation, Contributor Onboarding
epriestley moved T11561: Write a "Contributor Onboarding" document from Backlog to Meta on the Contributor Onboarding board.
Apr 9 2017, 11:28 AM · Documentation, Contributor Onboarding
epriestley moved T11476: Record transaction histories when users edit application capabilities from Backlog to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 11:28 AM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley moved T11217: Make Tokens modular / real application from Intermediate to Backlog on the Contributor Onboarding board.
Apr 9 2017, 11:27 AM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T8788: Allow querying for files by name.

We ultimately built an "ngram index" for this task, see T9979 for discussion.

Apr 9 2017, 11:24 AM · Contributor Onboarding, Files
epriestley moved T8788: Allow querying for files by name from Backlog to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 11:18 AM · Contributor Onboarding, Files
epriestley moved T11632: Display invisible characters on erroneous user input from Backlog to Basic on the Contributor Onboarding board.
Apr 9 2017, 11:17 AM · Restricted Project, Contributor Onboarding
epriestley added a comment to T11632: Display invisible characters on erroneous user input.
  • T11586 has context.
  • D16541 added PHUIInvisibleCharacterView and has usage examples.
  • Go hunt down as many error messages which include user input in a validation error as you can find/test and wrap them in PHUIInvisibleCharacterView. The task description lists some. I don't think there's any systematic way to find these, and we shouldn't expect to be exhaustive.
  • Close this when satisfied / bored / everything else is too much of a pain to test.
  • Primary goal here is just an onboarding goal of poking around some different applications, we haven't really seen users hit this stuff.
Apr 9 2017, 11:17 AM · Restricted Project, Contributor Onboarding
epriestley added a comment to T10828: File deletion should be queued up and run by daemons.
  • When you click "Delete File", we currently delete the file in the web process. Since we've supported enormous files and pluggable storage backends for a while, this could take an arbitrarily long amount of time to complete.
    • Instead, we want to flag the file as "deleted", hide it in the web UI, and queue up a task in the daemons to actually get rid of the data.
Apr 9 2017, 11:13 AM · Contributor Onboarding, Daemons, Files, Bug Report