Issue: Manual edits to /etc/shadow can be problematic if mangled
Version:current/master/whatever secure.phabricator.com is running
Reproduction steps:
https://secure.phabricator.com/book/phabricator/article/diffusion_hosting/#additional-ssh-user-conf contains the following advisement...
/etc/shadow: Open /etc/shadow and find the line for the vcs-user account.
The second field (which is the password field) must not be set to !!. This value will prevent login. If it is set to !!, edit it and set it to NP ("no password") instead.Recommended resolution:
Change verbiage to the following...
The second field (which is the password field) must not be set to !!. This value will prevent login. If it is set to !!, run 'usermod -p NP vcs-user' to block only password logins.