Page MenuHomePhabricator

Files "Temporary" badge is white-on-grey
Closed, ResolvedPublic

Description

Temporary files show a white-on-grey "temporary" badge:

Screen Shot 2017-04-04 at 11.53.50 AM.png (191×287 px, 16 KB)

The code tries to make this badge yellow:

$ttl = $file->getTTL();
if ($ttl !== null) {
  $ttl_tag = id(new PHUITagView())
    ->setType(PHUITagView::TYPE_STATE)
    ->setBackgroundColor(PHUITagView::COLOR_YELLOW)
    ->setName(pht('Temporary'));
  $header->addTag($ttl_tag);
}

@chad, I can probably fix this if you don't have any insight, but wasn't sure if maybe there's some bigger issue here like "yellow is no longer supported and we should remove the constant" or "yellow is supposed to work".

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley added a revision: Restricted Differential Revision.Apr 10 2017, 9:57 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 10 2017, 10:01 PM
epriestley added a commit: Restricted Diffusion Commit.