Page MenuHomePhabricator
Feed All Stories

Feb 19 2017

Mnkras updated the task description for T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.
Feb 19 2017, 6:37 PM · Diffusion, Feature Request
Mnkras created T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.
Feb 19 2017, 6:08 PM · Diffusion, Feature Request
cspeckmim added a comment to T12174: Home Menu Errata.

Just tested this out with having global menu items of Create Task forms and Projects, each which are only visible based on some policy - looks to not have any issues hiding/showing based on those policies. Thanks for all this, when I get these changes into production install I'll check for feedback but I'm anticipating it will be a smoother experience for everyone.

Feb 19 2017, 5:18 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

This is currently the scalability and stability bottleneck for deployments, but should be relatively easy to fix.

Feb 19 2017, 5:13 PM · Ops, Phacility
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

(For anyone following along, some additional discussion of clustershell in T2794.)

Feb 19 2017, 4:06 PM · Ops, Phacility
larryzhao closed Q570: How to install `Phrequent`? as resolved.
Feb 19 2017, 3:42 PM · Phrequent, Arcanist
larryzhao added a comment to Q570: How to install `Phrequent`? (Answer 514).

@cspeckmim Thank you very much for the help.

Feb 19 2017, 3:42 PM
cspeckmim added Q570: How to install `Phrequent`? (Answer 514).
Feb 19 2017, 3:41 PM
larryzhao updated Q570: How to install `Phrequent`? from Got `ERR-CONDUIT-CALL: Method 'phrequent.push' belongs to application 'Phrequent', which is not installed.` to How to install `Phrequent`?.
Feb 19 2017, 3:22 PM · Phrequent, Arcanist
larryzhao updated Q570: How to install `Phrequent`? from to Got `ERR-CONDUIT-CALL: Method 'phrequent.push' belongs to application 'Phrequent', which is not installed.`.
Feb 19 2017, 3:09 PM · Phrequent, Arcanist
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 19 2017, 3:04 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 19 2017, 2:58 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 19 2017, 2:54 PM · Phage, Infrastructure
huangsj awarded T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag a Like token.
Feb 19 2017, 12:47 PM · Drydock, Diffusion
epriestley added a comment to T2794: Implement Phage (like Hypershell).

We'll open source everything that's general-purpose. (Currently, the only piece that's closed is the "plan" for Phacility deployments specifically. Since we don't have a generic "SSH" style plan as a starting point yet that plan is currently important, but we'll write generic plans or a general plan-executor or something eventually.)

Feb 19 2017, 12:37 PM · Phage, Infrastructure
larryzhao closed Q569: Got `ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define these parameters: 'arcanistProject'.` as resolved.
Feb 19 2017, 12:34 PM · Differential, Arcanist
larryzhao added Q569: Got `ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define these parameters: 'arcanistProject'.` (Answer 513).
Feb 19 2017, 12:34 PM
20after4 added a comment to T2794: Implement Phage (like Hypershell).

I totally get the motivation to have a strong collection of highly integrated tools which all work together seamlessly and provide a value that is larger than the sum of it's parts.

Feb 19 2017, 11:42 AM · Phage, Infrastructure
avivey added Q569: Got `ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define these parameters: 'arcanistProject'.` (Answer 512).
Feb 19 2017, 10:39 AM
larryzhao updated the question details for Q569: Got `ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define these parameters: 'arcanistProject'.`.
Feb 19 2017, 8:21 AM · Differential, Arcanist
larryzhao updated Q569: Got `ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define these parameters: 'arcanistProject'.` from to Got `ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define these parameters: 'arcanistProject'.`.
Feb 19 2017, 8:20 AM · Differential, Arcanist
epriestley merged T12276: Allow to configure arc commit message into T2920: Modularize the pipeline for producing final commit messages.
Feb 19 2017, 1:12 AM · Arcanist
epriestley merged task T12276: Allow to configure arc commit message into T2920: Modularize the pipeline for producing final commit messages.
Feb 19 2017, 1:12 AM · KDE, Feature Request
milianw added a comment to T12276: Allow to configure arc commit message.

Note that I'm not asking for this to be done for everyone, by default. Rather, I want this to be an opt-in feature. I imagine this is also what the people who voted for the question on StackOverflow have in mind.

Feb 19 2017, 12:03 AM · KDE, Feature Request

Feb 18 2017

chad added a comment to T12276: Allow to configure arc commit message.

I was commenting on your suggestion to remove unwanted items from commit messages. It's a compliance feature for many businesses who need complete audit trails.

Feb 18 2017, 11:55 PM · KDE, Feature Request
milianw added a comment to T12276: Allow to configure arc commit message.

@chad sorry, but I don't follow, what has accountability to do with this?

Feb 18 2017, 11:48 PM · KDE, Feature Request
epriestley added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

I believe we only get it wrong in the very specific case where you're attending a "Busy" event and an "Away" event at the same time. We'll show the dot color for whichever event started first, so if the "Busy" event started before the "Away" event you get an orange dot instead of a red dot (if the "Away" event started first, we show a red dot, but that's the right color to show).

Feb 18 2017, 9:11 PM · Calendar, Bug Report
chad changed the visibility for T555: Hyperlink from comments summaries to inline comments in the non-current revision.
Feb 18 2017, 7:52 PM · Differential
cspeckmim added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

rare

Maybe my calendar setup isn't common but I usually have multiple overlapping meetings each week - I know others at the same company manage their calendar in a similar fashion.

Feb 18 2017, 6:27 PM · Calendar, Bug Report
dtf added a comment to T12278: Choose specific form on Create Subtask.

An example.

Feb 18 2017, 3:30 PM · Maniphest, Feature Request
mirrom added a comment to T12278: Choose specific form on Create Subtask.

No, I do not work together with @dtf, but I guess we have a similar workflow.

Feb 18 2017, 2:19 PM · Maniphest, Feature Request
mirrom added a comment to T12277: Show the points of the sub and parent tasks in the Task Graph.

Thanks for your feedback! As you said it might be very complex to automatically sum up the points of all sub tasks. Of course this would be a very nice to have, but it was not my intention to request this quite complex feature. For us a "simple" UI change would be absolutely sufficient. It would be great to see the points of all sub tasks in the Task Graph at a glance.

Feb 18 2017, 2:07 PM · Maniphest, Feature Request
mirrom added a comment to T12277: Show the points of the sub and parent tasks in the Task Graph.

Thanks for your feedback! As you said it might be very complex to automatically sum up the points of all sub tasks. Of course this would be a very nice to have, but it was not my intention to request this quite complex feature. For us a "simple" UI change would be absolutely sufficient. It would be great to see the points of all sub tasks in the Task Graph at a glance.

Feb 18 2017, 2:07 PM · Maniphest, Feature Request
epriestley added a comment to T12278: Choose specific form on Create Subtask.

You should already be able to use custom forms to limit access to advanced fields by user, as we do on this install. If you (a user who is not a member of Community) try to create a new subtask here, I believe you will find that you can not access fields like "Assigned To" or "Priority". However, members of Community can.

Feb 18 2017, 1:51 PM · Maniphest, Feature Request
epriestley added a comment to T2794: Implement Phage (like Hypershell).

It looks like clustershell is doing something pretty similar to Hypershell/Phage in its "gateway" mode (but it looks like it can't bootstrap itself and doesn't have a web UI).

Feb 18 2017, 1:45 PM · Phage, Infrastructure
dtf added a comment to T12278: Choose specific form on Create Subtask.

Well, we do use Workboards and Milestones, Subprojects, but we'd like to have that feature. We have multiple custom fields configured, which are relevant to different parts of the team. I would like to be able to configure different sets of forms for those subteams so our newcomers don't break things they don't yet understand or shouldn't touch.

Feb 18 2017, 10:38 AM · Maniphest, Feature Request
avivey added a comment to T10687: jx-tooltip does whatever it feels like.

Some more shenanigans:

Feb 18 2017, 8:13 AM · PHUI, Bug Report
20after4 awarded T12157: Make it visibly clearer that a Phabricator user account has been disabled a Orange Medal token.
Feb 18 2017, 6:38 AM · Profile, Feature Request
20after4 added a comment to T2794: Implement Phage (like Hypershell).

Cool stuff. I didn't see you already had made so much progress before I commented on T12218. You can safely disregard my clustershell suggestion.

Feb 18 2017, 6:37 AM · Phage, Infrastructure
20after4 added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

@epriestley: Have you seen clustershell? It's a massively scaleable management shell with some pretty interesting features. Wikimedia operations are adopting it in place of a lot of dsh and saltstack stuff. From what I have seen it is a really solid framework to build upon.

Feb 18 2017, 6:24 AM · Ops, Phacility
chad added a comment to T12202: Upgrade Guide: Home Menu Items.

I'm probably going to add a note to the dashboard dialog explaining home special casing better

Feb 18 2017, 3:15 AM · Guides, Installing & Upgrading, Profile Menu Item
epriestley removed a watcher for Maniphest: • s935l4h.
Feb 18 2017, 2:57 AM
epriestley added a comment to T12277: Show the points of the sub and parent tasks in the Task Graph.

T12278 suggests that "sprint tasks" are being used in this workflow -- not milestones -- and "backlog tasks" are being used -- not columns. But this task also mentions columns and workboards. A more detailed description of your workflow would be helpful in understanding where the intended tools (milestones and columns) are falling short.

Feb 18 2017, 2:54 AM · Maniphest, Feature Request
epriestley added a comment to T12278: Choose specific form on Create Subtask.

Why do you create backlog tasks or sprint tasks instead of using Columns on Workboards or Milestones in Projects?

Feb 18 2017, 2:52 AM · Maniphest, Feature Request
epriestley triaged T12277: Show the points of the sub and parent tasks in the Task Graph as Wishlist priority.

I don't think this is necessarily unreasonable, but I'd like to see significantly more interest in it from other installs before we pursue it.

Feb 18 2017, 2:50 AM · Maniphest, Feature Request
epriestley closed T12222: Add custom fields to the "Task Action..." menu as Invalid.

Unfortunately, this doesn't seem to be moving toward an upstreamable feature request which completely describes a root problem. I'm not sure how we can make what we're asking for more clear. We've already spent a significant amount of time on this and need to move on to other things.

Feb 18 2017, 2:36 AM · Maniphest, Feature Request
epriestley closed T10794: Upgrading: Changes to Aphlict (Real-Time Notifications) Configuration as Resolved.

This has been live for a while now.

Feb 18 2017, 2:32 AM · Installing & Upgrading, Aphlict
epriestley closed T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext) as Resolved.

This has seemed stable for a while. We've fixed a few stemming issues and have T12137 and some other followups outstanding, but these generally are not issues that are fundamental to InnoDB Fulltext.

Feb 18 2017, 2:31 AM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley closed T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages as Resolved.

I think we mostly managed to get installs through this.

Feb 18 2017, 2:30 AM · Installing & Upgrading, Differential
epriestley closed T8623: Upgrading: Differential Hunk Migration as Resolved.

This has now been live for a while without anyone hitting real issues other than the minor hiccup in T12090. T8475 is an eventual followup.

Feb 18 2017, 2:27 AM · Installing & Upgrading, Differential, Guides
epriestley closed T12202: Upgrade Guide: Home Menu Items as Resolved.

This has been live for a couple of weeks and I don't think we've seen too much confusion from users.

Feb 18 2017, 2:25 AM · Guides, Installing & Upgrading, Profile Menu Item
epriestley closed T12268: Make the grey "Unverified User" dot accurately reflect the new universal behavior as Resolved.

I think D17374 covered everything I wanted to cover.

Feb 18 2017, 2:18 AM · Mail, People
epriestley added a comment to T12280: mov and m4v videos don't play .

See also T12079 and T12219, although I'm not sure if either of those are duplicates of this.

Feb 18 2017, 2:15 AM · Bug Report
epriestley added projects to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?): Design, Internet Explorer.
Feb 18 2017, 2:14 AM · Internet Explorer, Design
epriestley added a comment to T12275: Allow to rename applications.

The point of my comment was that as someone familiar with KDE, which is broadly a project with a somewhat-similar application structure and somewhat-similar application names, you should reasonably be aware that what you are asking for is not likely to be trivial or straightforward.

Feb 18 2017, 2:03 AM · Feature Request
epriestley edited the content of Changelog.
Feb 18 2017, 1:42 AM
epriestley created 2017 Week 7 (Late February).
Feb 18 2017, 1:41 AM
milianw added a comment to T12275: Allow to rename applications.

This request comes from me. I'm an individual. I have tagged it as KDE since I want to use it on the KDE instance of phabricator. I'm part of KDE, but I'm _not_ KDE.

Feb 18 2017, 1:26 AM · Feature Request
chad added a comment to T12276: Allow to configure arc commit message.

@milianw Please keep in mind Phabricator is an enterprise tool, and the majority of installs (99%) are businesses who rely on the accountability we've built into the software.

Feb 18 2017, 1:25 AM · KDE, Feature Request
epriestley added a comment to T12276: Allow to configure arc commit message.

See T10622.

Feb 18 2017, 1:15 AM · KDE, Feature Request
milianw added a comment to T12276: Allow to configure arc commit message.

Another reason for having a template:

Feb 18 2017, 1:14 AM · KDE, Feature Request
epriestley added a comment to T12275: Allow to rename applications.

I find it noteworthy that this request comes from KDE, a project which ships a large number of applications with nonliteral names featuring "K" wordplay ("Konversation" instead of "IRC Client", "Konqueror" instead of "Browser", "KCachegrind" instead of "Graphical Frontend for Cachegrind, a Cache Profiler that is part of Valgrind, a Profiler Suite With An Unfortunate Nonliteral Name", and so on).

Feb 18 2017, 12:54 AM · Feature Request
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

We're currently at ~82% cluster fullness which makes me slightly uncomfortable, but I'm not going to add more hardware quite yet since I think I can probably get "scale to 0" into production next week. If it's more involved than I think I'll likely put shards 017-020 into production in the next week or so.

Feb 18 2017, 12:42 AM · Ops, Phacility
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Can't the same tricks used to make a single web server handle multiple instances be used for the daemons?

Feb 18 2017, 12:35 AM · Ops, Phacility

Feb 17 2017

epriestley closed T12290: `arc diff` should copy the differential URL to clipboard as Invalid.

Yes, our expectation is that email solves the problem of notifying reviewers. If email isn't solving this problem, we'd prefer to try to fix that rather than add features to support a workflow where you manually copy-paste links into a Slack channel, since this is a fundamentally narrow, unscalable workflow and the feature isn't practical to implement in environments where arc is run on a remote host.

Feb 17 2017, 11:55 PM · Feature Request
achals added a comment to T12290: `arc diff` should copy the differential URL to clipboard.

Fair enough - my team is odd in that we get a deluge of emails for diffs we're CC'd on since we own a platform for other developers, so we end up communicating diffs about the platform itself via chat instead of email. We should probably fix our email filters instead.

Feb 17 2017, 11:43 PM · Feature Request
chad added a comment to T12290: `arc diff` should copy the differential URL to clipboard.

Then you wouldn't have to paste it into a window!

Feb 17 2017, 11:36 PM · Feature Request
chad added a comment to T12290: `arc diff` should copy the differential URL to clipboard.

if only differential sent people reviews automatically.

Feb 17 2017, 11:36 PM · Feature Request
epriestley added a revision to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?): Unknown Object (Differential Revision).
Feb 17 2017, 11:34 PM · Internet Explorer, Design
chad added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

M'Kay

Feb 17 2017, 11:33 PM · Internet Explorer, Design
epriestley added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

I'll just undo D17361 for now since the "MMMMMMMMMMMMMMMMM" thing is only a theoretical problem, and we can think about this more carefully outside of the context of a release cut.

Feb 17 2017, 11:30 PM · Internet Explorer, Design
epriestley added a revision to T12218: Reduce the operational cost of a larger Phacility cluster: Unknown Object (Differential Revision).
Feb 17 2017, 11:18 PM · Ops, Phacility
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 17 2017, 11:14 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 17 2017, 10:59 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 17 2017, 10:42 PM · Phage, Infrastructure
epriestley added a comment to T12290: `arc diff` should copy the differential URL to clipboard.

What are two other ways we could solve the problem you're running into?

Feb 17 2017, 10:40 PM · Feature Request
achals updated the task description for T12290: `arc diff` should copy the differential URL to clipboard.
Feb 17 2017, 10:27 PM · Feature Request
achals created T12290: `arc diff` should copy the differential URL to clipboard.
Feb 17 2017, 10:19 PM · Feature Request
chad awarded T2794: Implement Phage (like Hypershell) a 100 token.
Feb 17 2017, 10:04 PM · Phage, Infrastructure
epriestley renamed T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate from calendar: away should be displayed first than busy to When a user is attending multiple overlapping events, computation of availability state may not be accurate.
Feb 17 2017, 9:08 PM · Calendar, Bug Report
epriestley added a comment to T2794: Implement Phage (like Hypershell).

This is still a shallow ghost of Hypershell, but I successfully deployed secure with it:

Feb 17 2017, 8:56 PM · Phage, Infrastructure
lvital updated subscribers of T12272: Allow users to accept on behalf of packages they control a containing package for.
Feb 17 2017, 7:52 PM · Owners, Audit, Restricted Project, Differential
chad added a comment to T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website.

We generally don't consider a root problem of "Phabricator lacks feature" as a reason to accept a feature request. We still need to know the underlying problem.

Feb 17 2017, 7:09 PM · Auth, Feature Request
jcox awarded F905540: cat3.png a 100 token.
Feb 17 2017, 6:59 PM
jcox awarded F905540: cat3.png a Burninate token.
Feb 17 2017, 6:59 PM
lvital added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

As far as "opt-in", are you mostly concerned about performance?

Feb 17 2017, 6:46 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

As far as "opt-in", are you mostly concerned about performance?

Feb 17 2017, 6:14 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

(I'm not sure how "Compatibility Mode" and the DOM inspector are interacting, so maybe I'm just using it incorrectly.)

Feb 17 2017, 5:59 PM · Internet Explorer, Design
lvital added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.
NOTE: Since packages do not own paths exclusively, any user can create a package on / of every repository and be allowed to force-accept every package review because their "everything" package is now a containing package for all other packages. However, they could already just remove the reviewers, so I don't think this is important. We could add options to Owners (e.g., an optional whitelist of "Stronger" packages) or something to prevent this, but I don't plan to do this. Just fire anyone abusing it.
Feb 17 2017, 5:57 PM · Owners, Audit, Restricted Project, Differential
• pasik updated the task description for T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website.
Feb 17 2017, 5:53 PM · Auth, Feature Request
epriestley added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

Here's the note in PhabricatorPeopleQuery about this:

Feb 17 2017, 5:42 PM · Calendar, Bug Report
epriestley added a comment to T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website.

I don't think this is worth bringing upstream. It very occasionally saves users one click on an otherwise straightforward workflow, but requires significant complexity and maintenance from the upstream.

Feb 17 2017, 5:40 PM · Auth, Feature Request
epriestley added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

According to compatibility mode on my machine (Windows 7, IE 11, in IE10 mode), there is no crumb bug in IE10 if float: left is removed. This isn't consistent with T5902 or with other results I got (e.g., this thing says there is such a bug).

Feb 17 2017, 5:29 PM · Internet Explorer, Design
chad added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

https://msdn.microsoft.com/en-us/library/dn255001(v=vs.85).aspx

Feb 17 2017, 5:24 PM · Internet Explorer, Design
chad added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

why can't you test 8-10? I thought you could do that with the inspection tools?

Feb 17 2017, 5:22 PM · Internet Explorer, Design
Luke081515.2 created T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.
Feb 17 2017, 5:22 PM · Calendar, Bug Report
epriestley added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

Are you OK with this plan?

Feb 17 2017, 5:20 PM · Internet Explorer, Design
epriestley added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

I made some effort to fix this, but without much headway:

Feb 17 2017, 5:16 PM · Internet Explorer, Design
chad added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

just revert the change if you want... or fix

Feb 17 2017, 5:15 PM · Internet Explorer, Design
chad added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

Thanks, Safari

Feb 17 2017, 5:13 PM · Internet Explorer, Design