Page MenuHomePhabricator

Hyperlink from comments summaries to inline comments in the non-current revision
Closed, ResolvedPublic

Description

It's really useful to be able to look at the summary of comments and click on the line number to jump to an inline comment. This doesn't work if the comment was on a revision other than the current one, though. There are two cases:

  • The inline comment was on a revision displayed on the left in Differential. For example, if I put Diff 1 up and get comments on it, update it to Diff 2, and then put Diff 1 and Diff 2 side-by-side, the comment summaries for Diff 1 don't hyperlink into Diff 1.
  • The comment was on a revision not currently displayed in Differential. Imagine the above scenario but with the Base revision and Diff 2 displayed. I can still read the comment summaries for Diff 1 but they don't link into it.

Revisions and Commits

Related Objects

Event Timeline

epriestley triaged this task as Normal priority.Oct 14 2011, 7:40 PM

I think we might have a dupe of this filed somewhere; I'll merge if I can find it. This is definitely something that should be fixed at some point. Related tasks are:

  • {T449}
  • {T492}
epriestley changed file(s), attached 0: ; detached 0: .Jan 6 2012, 3:39 PM
epriestley added subscribers: codeblock, fmoo.

◀ Merged tasks: T449.

This diff has received wide and sincere praise in the form of comments such as "you are my new favorite person", "This would be a good time for you to put your name of the ballot for Prom Queen", and "we should hire this guy".

chad changed the visibility from "All Users" to "Public (No Login Required)".Feb 18 2017, 7:52 PM