Feed All Stories
Aug 12 2020
Aug 12 2020
epriestley committed rP7fd6bf26a949: Modernize "Author" and "Committer" rendering for commits (authored by epriestley).
Modernize "Author" and "Committer" rendering for commits
epriestley committed rP81e4e5b7f9c9: Remove construction of "author" information from "LastModified" payload in… (authored by epriestley).
Remove construction of "author" information from "LastModified" payload in…
epriestley requested review of D21440: Fix some content/background overflow issues with commit graph lists.
epriestley committed rP545417597322: Coerce Chrome into breaking monospaced text when printing tables to PDFs (authored by epriestley).
Coerce Chrome into breaking monospaced text when printing tables to PDFs
epriestley added a comment to D21438: Find the per-worktree .git directory when using git-worktree.
To be completely clear: I'm not going to accept any features upstream which zero customers are interested in. It doesn't matter if they're simple or complicated. If no customers want it, it isn't coming upstream.
arichardson added a comment to D21438: Find the per-worktree .git directory when using git-worktree.
I don't expect any sophisticated git-worktree support. This is a simple change that allows arc get-config/set-config to work correctly when invoked from a worktree. It might also fix some other cases where arc expects $identity->localMetaDir to be a directory which previously wasn't the case for worktrees.
Aug 11 2020
Aug 11 2020
epriestley triaged T13567: Arcanist does not decode unicode filenames in Git before passing them to linters as Low priority.
epriestley renamed T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits from Improve fallback behavior for "arc branches/bookmarks" to Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits.
epriestley triaged T13565: Filesystem write failure error messages lack tailoring, notably in DeferredLog as Normal priority.
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
epriestley added a comment to T13564: Remarkup tables should show all content when printed to PDF.
Adding overflow-wrap: anywhere appears to fix this without breaking anything.
epriestley triaged T13564: Remarkup tables should show all content when printed to PDF as Normal priority.
epriestley triaged T13563: On Windows, Arcanist tries and fails to set stdin nonblocking while reading the stream as Low priority.
epriestley added a comment to D21438: Find the per-worktree .git directory when using git-worktree.
There's currently no customer interest in worktree support. The use cases in T9924 seem flimsy to me so I don't currently plan to support worktrees in the absence of customer interest. See also ArcanistGitWorkingCopy.
arichardson updated the diff for D21438: Find the per-worktree .git directory when using git-worktree.
- fix $vcs -> $vcs_type
arichardson requested review of D21438: Find the per-worktree .git directory when using git-worktree.
epriestley updated the task description for T13561: Allow the daemons to generate tasks dynamically at runtime.
epriestley triaged T13561: Allow the daemons to generate tasks dynamically at runtime as Normal priority.
epriestley added a comment to T13125: Plans: Code coverage reporting.
PHI1816 would also like dimensional coverage: coverage by language; coverage by team/owner. This is perhaps worth considering in how coverage is aggregated.
epriestley triaged T11372: Multiple coverage columns for different types of code coverage as Wishlist priority.
epriestley updated the task description for T13125: Plans: Code coverage reporting.
Aug 10 2020
Aug 10 2020
Make "Quote" work properly in Pholio
epriestley triaged T13560: "Large number of changes" transaction timeline banner may hide a single change as Wishlist priority.
epriestley requested review of D21437: Make "Quote" work properly in Pholio.
epriestley triaged T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting as Wishlist priority.
Aug 8 2020
Aug 8 2020
epriestley edited the content of Changelog.
(stable) Promote 2020 Week 31
epriestley created an object: 2020 Week 31 (Early August).
Aug 5 2020
Aug 5 2020
epriestley committed rPce0dc9a2ba2c: Correct an apparent off-by-one error when adjusting inlines across revision… (authored by epriestley).
Correct an apparent off-by-one error when adjusting inlines across revision…
epriestley committed rPdbdfac1e072e: Recover inline comments which are "adjusted" off the end of a diff (authored by epriestley).
Recover inline comments which are "adjusted" off the end of a diff
epriestley requested review of D21435: Recover inline comments which are "adjusted" off the end of a diff.
epriestley committed rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or… (authored by epriestley).
In Jupyter notebooks, read strings stored in the raw as either "string" or…
epriestley updated the task description for T13241: Guide: SMS is Insecure.
epriestley added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
With newer inline comment functionality there is no ability to create submitted inline comments for bots or via API directly.
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
epriestley committed rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines (authored by epriestley).
In 1-up source diffs, retain the "No newline at end of file" on "\" lines
epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
epriestley added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
What is now programmatical way to "submit" unsubmitted inline comments? Some users are using it to post comments from bots, now if we use differential.createinline api method all bot comments are visible as unsubmitted and looks like there is no way to set it in stone...
Aug 2 2020
Aug 2 2020
epriestley committed rP287b7485a68a: (stable) Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
(stable) Move "Wait for Previous Commits to Build" out of prototype
Jul 30 2020
Jul 30 2020
jg added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.
epriestley added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.
See PHI1833.
epriestley committed rPc1eeacd8500b: Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
Move "Wait for Previous Commits to Build" out of prototype
epriestley requested review of D21432: Move "Wait for Previous Commits to Build" out of prototype.
Jul 28 2020
Jul 28 2020
epriestley requested review of D21431: Improve handle/status list display on devices in commit graph lists.
epriestley requested review of D21430: Improve commit action item layout on mobile.
Jul 27 2020
Jul 27 2020
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 25 2020
Jul 25 2020
epriestley edited the content of Changelog.
(stable) Promote 2020 Week 29
(stable) Promote 2020 Week 29
epriestley created an object: 2020 Week 29 (Late July).
avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.
related to T3278, probably?
Jul 24 2020
Jul 24 2020
epriestley committed rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior (authored by epriestley).
Revert use of "user-select: all" to modify tab selection behavior
epriestley requested review of D21429: Revert use of "user-select: all" to modify tab selection behavior.
epriestley added a comment to D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
I reverted this in D21429, since it also makes these sequences select with a single click.
epriestley added a comment to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.
In D21426, I removed phd.trace and phd.verbose.
Jul 23 2020
Jul 23 2020
epriestley committed rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options (authored by epriestley).
Remove ancient "phd.trace" and "phd.verbose" configuration options
epriestley updated the diff for D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
- Include "obsolete config" setup checks.
epriestley requested review of D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
epriestley committed rP78d1b62bb8e9: Streamline handling of Futures and PIDs in daemons (authored by epriestley).
Streamline handling of Futures and PIDs in daemons
epriestley committed rP5f0535934d72: Manage PIDs more carefully in DaemonHandle (authored by epriestley).
Manage PIDs more carefully in DaemonHandle
epriestley committed rARCceb082ef6b29: Give Futures clearer start/end and exception semantics (authored by epriestley).
Give Futures clearer start/end and exception semantics
epriestley triaged T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes as Wishlist priority.
epriestley updated the diff for D21425: Streamline handling of Futures and PIDs in daemons.
- Use "$caught", not "$ex", to make the code less fragile.