Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 5:19 PM
Unknown Object (File)
Jun 3 2025, 10:47 PM
Unknown Object (File)
Apr 29 2025, 7:34 AM
Unknown Object (File)
Apr 27 2025, 2:04 PM
Unknown Object (File)
Apr 26 2025, 10:06 PM
Unknown Object (File)
Apr 19 2025, 7:26 PM
Unknown Object (File)
Apr 15 2025, 12:20 PM
Unknown Object (File)
Apr 8 2025, 1:57 PM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable