Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F18993545: D21429.id50989.diff
Wed, Nov 19, 8:10 AM
F18877432: D21429.diff
Thu, Nov 6, 8:23 AM
F18859742: D21429.diff
Sun, Nov 2, 5:07 AM
F18816531: D21429.id50989.diff
Oct 21 2025, 7:30 AM
F18809405: D21429.id.diff
Oct 19 2025, 1:43 PM
F18807028: D21429.diff
Oct 18 2025, 10:38 PM
F18778046: D21429.id50990.diff
Oct 11 2025, 7:31 AM
F18760782: D21429.diff
Oct 6 2025, 10:25 AM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable