Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 9:27 AM
Unknown Object (File)
Oct 18 2024, 2:53 PM
Unknown Object (File)
Oct 3 2024, 3:57 PM
Unknown Object (File)
Sep 6 2024, 8:27 AM
Unknown Object (File)
Sep 6 2024, 8:27 AM
Unknown Object (File)
Sep 6 2024, 8:27 AM
Unknown Object (File)
Sep 2 2024, 9:49 AM
Unknown Object (File)
Sep 1 2024, 3:42 AM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable