Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F18737018: D21429.id.diff
Wed, Oct 1, 8:43 AM
F18734339: D21429.id.diff
Tue, Sep 30, 10:52 PM
F18606745: D21429.diff
Sat, Sep 13, 10:33 PM
F18571168: D21429.id50990.diff
Wed, Sep 10, 4:47 AM
F18571167: D21429.id50989.diff
Wed, Sep 10, 4:47 AM
F18364517: D21429.id50989.diff
Aug 27 2025, 7:23 PM
F18361064: D21429.diff
Aug 27 2025, 11:22 AM
F18110315: D21429.id50990.diff
Aug 11 2025, 6:24 PM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable