Page MenuHomePhabricator
Differential D21429

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic
Actions

Authored by epriestley on Fri, Jul 24, 8:40 PM.

Details

Reviewers
None
Commits
rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior
Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Jul 24, 8:40 PM
epriestley mentioned this in D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.Fri, Jul 24, 8:40 PM
Harbormaster completed remote builds in B24807: Diff 50989.Fri, Jul 24, 8:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jul 24, 8:41 PM
epriestley requested review of this revision.
Closed by commit rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
parser/
7 lines
__tests__/
4 lines
webroot/
rsrc/
css/
core/
5 lines

Diff 50990

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php

Loading...
View Options

webroot/rsrc/css/core/syntax.css

Loading...
Phabricator · Built by Phacility