Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
F19924079: D21432.id.diff
Tue, Apr 7, 5:24 AM
F19900023: D21432.id50998.diff
Mon, Mar 30, 1:13 AM
F19609752: D21432.id50998.diff
Feb 3 2026, 2:15 PM
F19303709: D21432.diff
Dec 24 2025, 4:50 AM
F19075910: D21432.id50997.diff
Dec 1 2025, 11:14 AM
F19054252: D21432.id.diff
Nov 28 2025, 11:31 AM
F19009633: D21432.diff
Nov 21 2025, 11:51 PM
F19003663: D21432.diff
Nov 21 2025, 9:28 AM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable