Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype

Authored by epriestley on Thu, Jul 30, 7:43 PM.



Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jul 30, 7:43 PM
Owners added a subscriber: Restricted Owners Package.Thu, Jul 30, 7:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 30, 7:45 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.