Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
F19009633: D21432.diff
Fri, Nov 21, 11:51 PM
F19003663: D21432.diff
Fri, Nov 21, 9:28 AM
F18813894: D21432.id50998.diff
Oct 20 2025, 7:45 PM
F18812838: D21432.id50997.diff
Oct 20 2025, 12:36 PM
F18809310: D21432.id.diff
Oct 19 2025, 12:53 PM
F18804545: D21432.diff
Oct 18 2025, 9:26 AM
F18803502: D21432.diff
Oct 18 2025, 12:35 AM
F18788689: D21432.id.diff
Oct 15 2025, 6:03 AM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable