Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
F18788689: D21432.id.diff
Wed, Oct 15, 6:03 AM
F18766950: D21432.id50997.diff
Tue, Oct 7, 7:35 PM
F18740736: D21432.diff
Thu, Oct 2, 5:12 AM
F18672773: D21432.id50997.diff
Thu, Sep 25, 8:11 AM
F18672768: D21432.id50998.diff
Thu, Sep 25, 8:11 AM
F18672765: D21432.id.diff
Thu, Sep 25, 8:11 AM
F18672760: D21432.diff
Thu, Sep 25, 8:11 AM
F18614419: D21432.id.diff
Sep 14 2025, 12:51 PM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable