Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 3, 9:36 AM
Unknown Object (File)
Tue, Jun 3, 4:07 AM
Unknown Object (File)
May 3 2025, 11:52 PM
Unknown Object (File)
Apr 29 2025, 8:29 AM
Unknown Object (File)
Apr 28 2025, 9:49 AM
Unknown Object (File)
Apr 27 2025, 1:16 PM
Unknown Object (File)
Apr 26 2025, 9:02 AM
Unknown Object (File)
Apr 5 2025, 5:57 AM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable