Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
F14079287: D21432.id50997.diff
Fri, Nov 22, 7:36 AM
Unknown Object (File)
Thu, Nov 21, 9:09 AM
Unknown Object (File)
Wed, Nov 20, 11:35 PM
Unknown Object (File)
Sun, Nov 17, 8:46 AM
Unknown Object (File)
Sat, Nov 9, 11:18 AM
Unknown Object (File)
Tue, Oct 29, 11:10 PM
Unknown Object (File)
Sun, Oct 27, 10:58 AM
Unknown Object (File)
Fri, Oct 25, 8:20 AM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable