Page MenuHomePhabricator

Make the "attach_inlines" parameter to "differential.createcomment" a no-op
ClosedPublic

Authored by epriestley on Wed, May 6, 6:28 PM.

Details

Summary

Ref T13513. See that task for some discussion. This prepares to lift "loadUnsubmittedInlineComments(...)" into shared code.

Test Plan

Grepped for callers, found none in the upstream. This is a backward compatibilty break. See T13513.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 6, 6:28 PM
epriestley requested review of this revision.Wed, May 6, 6:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 7, 10:55 PM
This revision was automatically updated to reflect the committed changes.