In 1-up source diffs, retain the "No newline at end of file" on "\" lines
ClosedPublic
Actions

Authored by epriestley on Aug 5 2020, 4:49 PM.

Tags

None

Referenced Files

	F18759774: D21433.id51003.diff
	Mon, Oct 6, 5:51 AM

	F18745709: D21433.id51002.diff
	Fri, Oct 3, 8:52 AM

	F18699304: D21433.id51003.diff
	Sat, Sep 27, 12:40 PM

	F18672451: D21433.id.diff
	Thu, Sep 25, 7:34 AM

	F18672449: D21433.id51002.diff
	Thu, Sep 25, 7:34 AM

	F18671180: D21433.diff
	Thu, Sep 25, 2:57 AM

	F18625779: D21433.diff
	Sep 15 2025, 11:31 PM

	F18617799: D21433.id51003.diff
	Sep 14 2025, 10:12 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines

Summary

See PHI1839. Currently, the "No newline at end of file" text is dropped in the 1-up diff view for changes that affect a file with no trailing newline.

Track it through the construction of diff primitivies more carefully.

Test Plan

Screen Shot 2020-08-05 at 9.43.24 AM.png (549×327 px, 35 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 5 2020, 4:49 PM

Harbormaster completed remote builds in B24819: Diff 51002.Aug 5 2020, 4:50 PM

epriestley requested review of this revision.Aug 5 2020, 4:50 PM

epriestley mentioned this in T13557: Unified diffs could do a better job of rendering omitted trailing newlines.Aug 5 2020, 5:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 5:17 PM

Closed by commit rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

8 lines

DifferentialChangesetRenderer.php

4 lines

Diff 51003

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php