Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Jul 23 2020, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:40 PM
Unknown Object (File)
Wed, Mar 27, 12:39 PM
Unknown Object (File)
Sun, Mar 10, 7:57 PM
Unknown Object (File)
Feb 20 2024, 7:00 AM
Unknown Object (File)
Jan 25 2024, 2:23 AM
Unknown Object (File)
Jan 12 2024, 4:47 PM
Unknown Object (File)
Jan 9 2024, 8:05 AM
Unknown Object (File)
Jan 6 2024, 11:35 PM
Subscribers
None

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable