Differential D21426

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic
Actions

Authored by epriestley on Thu, Jul 23, 7:22 PM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes
Commits: rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jul 23, 7:22 PM

Harbormaster completed remote builds in B24802: Diff 50982.Thu, Jul 23, 7:23 PM

epriestley requested review of this revision.Thu, Jul 23, 7:23 PM

Include "obsolete config" setup checks.

Harbormaster completed remote builds in B24803: Diff 50983.Thu, Jul 23, 7:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 23, 7:31 PM

Closed by commit rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options.

epriestley mentioned this in T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.Fri, Jul 24, 12:18 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorDaemonsSetupCheck.php

23 lines

PhabricatorExtraConfigSetupCheck.php

6 lines

option/

PhabricatorPHDConfigOptions.php

32 lines

daemon/

management/

PhabricatorDaemonManagementWorkflow.php

4 lines

infrastructure/

daemon/

workers/

PhabricatorTaskmasterDaemon.php

2 lines

Diff 50984

src/applications/config/check/PhabricatorDaemonsSetupCheck.php

Loading...

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/config/option/PhabricatorPHDConfigOptions.php

Loading...

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

Loading...