Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Jul 23 2020, 7:22 PM.
Tags
None
Referenced Files
F15583080: D21426.id.diff
Wed, May 7, 7:47 PM
F15580823: D21426.id50983.diff
Wed, May 7, 7:59 AM
F15578692: D21426.diff
Tue, May 6, 8:22 PM
F15482066: D21426.id50984.diff
Apr 9 2025, 2:36 AM
F15478813: D21426.id50982.diff
Apr 8 2025, 2:58 AM
F15471120: D21426.id50982.diff
Apr 5 2025, 3:22 AM
F15468039: D21426.id.diff
Apr 3 2025, 7:39 PM
F15466680: D21426.id50983.diff
Apr 3 2025, 8:14 AM
Subscribers
None

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable