Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Jul 23 2020, 7:22 PM.
Tags
None
Referenced Files
F17760441: D21426.id50984.diff
Tue, Jul 22, 7:35 PM
F17759093: D21426.id50982.diff
Tue, Jul 22, 6:03 PM
F17759000: D21426.id50983.diff
Tue, Jul 22, 5:56 PM
F17738674: D21426.diff
Mon, Jul 21, 12:20 AM
Unknown Object (File)
Jun 8 2025, 8:10 PM
Unknown Object (File)
May 25 2025, 1:35 AM
Unknown Object (File)
May 7 2025, 7:47 PM
Unknown Object (File)
May 7 2025, 7:59 AM
Subscribers
None

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable