Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Thu, Jul 23, 7:22 PM.

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jul 23, 7:22 PM
epriestley requested review of this revision.Thu, Jul 23, 7:23 PM
epriestley updated this revision to Diff 50983.Thu, Jul 23, 7:28 PM
  • Include "obsolete config" setup checks.
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 23, 7:31 PM
This revision was automatically updated to reflect the committed changes.