HomePhabricator

In 1-up source diffs, retain the "No newline at end of file" on "\" lines

Description

In 1-up source diffs, retain the "No newline at end of file" on "\" lines

Summary:
See PHI1839. Currently, the "No newline at end of file" text is dropped in the 1-up diff view for changes that affect a file with no trailing newline.

Track it through the construction of diff primitivies more carefully.

Test Plan:

Screen Shot 2020-08-05 at 9.43.24 AM.png (549×327 px, 35 KB)

Differential Revision: https://secure.phabricator.com/D21433

Details

Provenance
epriestleyAuthored on Aug 5 2020, 4:46 PM
epriestleyPushed on Aug 5 2020, 5:17 PM
Differential Revision
D21433: In 1-up source diffs, retain the "No newline at end of file" on "\" lines
Parents
rPc1eeacd8500b: Move "Wait for Previous Commits to Build" out of prototype
Branches
Unknown
Tags
Unknown
Build Status
Buildable 24820
Build 34242: Run Core Tests