Page MenuHomePhabricator

artms (Arturas Moskvinas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2014, 3:31 PM (285 w, 6 d)
Availability
Available

Recent Activity

Tue, Dec 10

artms committed rP4cd333b33fb1: Use same method to get object URI as used in DifferentialTransactionEditor and… (authored by artms).
Use same method to get object URI as used in DifferentialTransactionEditor and…
Tue, Dec 10, 3:37 PM
artms closed D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Tue, Dec 10, 3:37 PM

Mon, Dec 9

artms requested review of D20936: Pass context object to PhabricatorMetaMTAMailBody as this is done in parent class.
Mon, Dec 9, 11:32 AM
artms updated the test plan for D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Mon, Dec 9, 11:31 AM
artms requested review of D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Mon, Dec 9, 11:28 AM

Thu, Nov 28

artms created T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.
Thu, Nov 28, 10:57 AM

Nov 7 2019

artms abandoned D20891: Jupyter notebook.
Nov 7 2019, 1:50 PM
artms requested review of D20891: Jupyter notebook.
Nov 7 2019, 1:49 PM

Oct 31 2019

artms added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Reproduction script for some working checked out repository on master and repository permanentRefs is master:

head -c 20 /dev/random | base64 > giberish
git add -A
git commit -m 'Add giberish'
HEAD=$(git rev-list --reverse HEAD~..HEAD)
title=$(git log -n1 --pretty=format:%s HEAD)
title_q=$(printf '%s' "$title" | jq --raw-input --slurp .)
rawdiff=$(git diff-tree --root --cc --no-commit-id HEAD|jq --raw-input --slurp .)
diffid=$(echo "{\"diff\":${rawdiff}}" | arc call-conduit differential.createrawdiff | jq -e -r .response.id )
revid=$(echo "{\"diffid\": $diffid, \"fields\":{\"title\": $title_q}}" | arc call-conduit differential.createrevision | jq -r .response.revisionid)
git push origin HEAD:refs/heads/non-permanent-refs/D$revid
arc diff -m 'Message' --update $revid --head $HEAD "${HEAD}^"
sleep 60
# make sure pushed branch is parsed and then push changes, need to make sure metadata Differential Revision is not added so we cannot use `arc land` here
git push origin master
Oct 31 2019, 8:58 PM
artms added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

I will try to provide a script to reproduce flow one of our tools does while creating this regresion some time later today/tonight.

Oct 31 2019, 4:38 PM
artms added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Oh, sorry, I think I misunderstood what you're describing in your test plan -- you're saying that you're currently observing the revision not closing, and believe this fixes it. I'll see if I can reproduce this.

Oct 31 2019, 4:32 PM
artms added inline comments to D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.
Oct 31 2019, 3:05 PM
artms requested review of D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.
Oct 31 2019, 3:04 PM

Oct 30 2019

artms committed rPbcf15abcd33c: Return empty data if fact dimension is missing, not yet available (authored by artms).
Return empty data if fact dimension is missing, not yet available
Oct 30 2019, 2:34 PM
artms closed D20861: Return empty data if fact dimension is missing, not yet available.
Oct 30 2019, 2:34 PM

Oct 22 2019

artms added a task to D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality: T13416: Transaction logs may overheat explosively.
Oct 22 2019, 7:43 AM
artms added a revision to T13416: Transaction logs may overheat explosively: D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 22 2019, 7:43 AM · Feed

Oct 21 2019

artms requested review of D20861: Return empty data if fact dimension is missing, not yet available.
Oct 21 2019, 1:38 PM

Oct 18 2019

artms added a comment to T13427: Task to reproduce lack of transaction object validation.

Thanks!

Oct 18 2019, 6:35 AM · artms

Oct 17 2019

epriestley closed T13427: Task to reproduce lack of transaction object validation as Resolved.

This now renders properly; see T13429 for followup.

Oct 17 2019, 5:03 PM · artms

Oct 14 2019

artms added a project to T13427: Task to reproduce lack of transaction object validation: artms.
Oct 14 2019, 11:46 AM · artms
artms created T13427: Task to reproduce lack of transaction object validation.
Oct 14 2019, 11:45 AM · artms

Oct 10 2019

artms requested review of D20856: Allow partial response of transaction history if it is overheating.
Oct 10 2019, 1:48 PM

Oct 9 2019

artms requested review of D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 9 2019, 8:01 AM

Oct 2 2019

artms committed rP960c447aab7f: Support more than 9 portals (authored by artms).
Support more than 9 portals
Oct 2 2019, 7:36 PM
artms closed D20852: Support more than 9 portals.
Oct 2 2019, 7:36 PM
artms requested review of D20852: Support more than 9 portals.
Oct 2 2019, 7:32 PM

Sep 23 2019

artms renamed T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error from Conduit log paging is broken to Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error.
Sep 23 2019, 12:26 PM · Conduit
artms created T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error.
Sep 23 2019, 12:26 PM · Conduit

Jul 23 2019

artms committed rPcd449254256d: Allow users with no CAN_EDIT permissions to silence projects if they want to (authored by artms).
Allow users with no CAN_EDIT permissions to silence projects if they want to
Jul 23 2019, 10:14 AM
artms closed D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 23 2019, 10:14 AM

Jul 22 2019

artms requested review of D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 22 2019, 11:09 AM

Feb 6 2019

artms renamed T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"` from Phriction search has issues with paging and crashes with `PhrictionDocumentQuery" failed to return a value from getPagingValueMap() for column "rank"` to Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.
Feb 6 2019, 10:14 AM
artms added a comment to T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.

Forgot to mention that ordering set is relevance and also same issue happens if you search in maniphest, eg.: https://secure.phabricator.com/maniphest/query/Gk8I9e13KiTw/?after=12975

Feb 6 2019, 10:13 AM
artms updated the task description for T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.
Feb 6 2019, 9:58 AM
artms created T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.
Feb 6 2019, 9:58 AM

Sep 19 2018

artms added a comment to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

Uh, sorry, didn't mean to step on toes, take your time :) Just wanted to share/upstream our findings which improve overall performance for large phab installations

Sep 19 2018, 5:22 PM

Sep 18 2018

artms added a comment to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

Anything? This improves herald rule performance...

Sep 18 2018, 7:55 AM
artms abandoned D9642: Add phriction.new conduit endpoint.
Sep 18 2018, 7:55 AM

Sep 12 2018

Pawka awarded D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check a Yellow Medal token.
Sep 12 2018, 12:45 PM
artms updated the test plan for D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.
Sep 12 2018, 11:20 AM
artms added inline comments to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.
Sep 12 2018, 11:19 AM
artms requested review of D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.
Sep 12 2018, 11:16 AM

Aug 3 2018

artms awarded D19559: Deprecate Conduit method "diffusion.getrecentcommitsbypath" a Like token.
Aug 3 2018, 6:40 AM

Aug 2 2018

artms committed rP356b2781bcad: Gracefully fail request if non existing callsign is passed to… (authored by artms).
Gracefully fail request if non existing callsign is passed to…
Aug 2 2018, 4:49 PM
artms closed D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing.
Aug 2 2018, 4:49 PM
artms added a comment to D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing.

Uh, we had couple of cases and this caused extra 500s in logs...

Aug 2 2018, 4:48 PM
artms requested review of D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing.
Aug 2 2018, 2:46 PM
artms committed rP4c09e88c9582: Add parsing for ssh options (-o) which are passed when using GIT v2 wire… (authored by artms).
Add parsing for ssh options (-o) which are passed when using GIT v2 wire…
Aug 2 2018, 1:43 PM
artms closed D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Aug 2 2018, 1:43 PM

Aug 1 2018

artms updated the diff for D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
  • Throw error if unknown ssh option is passed
Aug 1 2018, 11:45 AM

Jul 30 2018

artms added inline comments to D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Jul 30 2018, 9:33 AM
artms updated the diff for D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
  • Allow only SendEnv=GIT_PROTOCOL ssh option
Jul 30 2018, 9:31 AM
artms planned changes to D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Jul 30 2018, 8:02 AM

Jul 27 2018

artms updated the diff for D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).

Old arcanist

Jul 27 2018, 7:55 AM
artms requested review of D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Jul 27 2018, 7:51 AM

Jan 20 2015

artms added a comment to D11296: Lets really skip item and not spin in loop....

Guys any progress with it... It is really hitting pull workers hard which spin in loop doing nothing but spaming logs about repository not pullable anymore...

Jan 20 2015, 7:59 AM

Jan 9 2015

artms requested review of D9642: Add phriction.new conduit endpoint.
Jan 9 2015, 11:48 AM
artms planned changes to D9642: Add phriction.new conduit endpoint.
Jan 9 2015, 11:47 AM
artms added inline comments to D11296: Lets really skip item and not spin in loop....
Jan 9 2015, 11:45 AM
artms retitled D11296: Lets really skip item and not spin in loop... from to Lets really skip item and not spin in loop....
Jan 9 2015, 11:40 AM

Jun 27 2014

artms added a comment to D9642: Add phriction.new conduit endpoint.

Any progress?

Jun 27 2014, 9:55 AM

Jun 20 2014

artms added a comment to D9642: Add phriction.new conduit endpoint.

Thanks @chad for a tip!

Jun 20 2014, 6:11 PM
artms updated the diff for D9642: Add phriction.new conduit endpoint.

Fixing lint issues

Jun 20 2014, 6:10 PM
artms added inline comments to D9642: Add phriction.new conduit endpoint.
Jun 20 2014, 3:41 PM
artms retitled D9642: Add phriction.new conduit endpoint from to Add phriction.new conduit endpoint.
Jun 20 2014, 3:40 PM