(stable) Promote 2020 Week 19
Audit Required686e51655bb0
Actions

Description

(stable) Promote 2020 Week 19

Details

Group Auditors

Provenance

epriestley	Authored on May 15 2020, 8:00 PM
epriestley	Pushed on May 15 2020, 8:00 PM

Parents

rPe959f934893c: Use a more consistent inline highlighting style with fewer redraws
rPebf254dac351: (stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine

Branches

Unknown

Tags

Unknown

Build Status

Buildable 24448
Build 33688: Run Core Tests

Event Timeline

epriestley committed rP686e51655bb0: (stable) Promote 2020 Week 19 (authored by epriestley).May 15 2020, 8:00 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptMay 15 2020, 8:00 PM

This commit now requires audit.May 15 2020, 8:00 PM

Harbormaster completed building B24448: rP686e51655bb0: (stable) Promote 2020 Week 19.May 15 2020, 8:01 PM

Merged Changes

e959f934893c Use a more consistent inline highlighting style with fewer redraws
Author
epriestley
Revisions
D21262: Use a more consistent inline highlighting style with fewer redraws
Browse Repository
Passed
No Audits
c666cb9f0bc7 Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Author
epriestley
Revisions
D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Browse Repository
Passed
No Audits
b1351d0fdb81 Remove code which overrides "diffusion.ssh-username" when instanced
Author
epriestley
Revisions
D21259: Remove code which overrides "diffusion.ssh-username" when instanced
Browse Repository
Passed
No Audits
3ee6b5393c77 Improve offset/range inline behavior for rich diffs and unified diffs
Author
epriestley
Revisions
D21257: Improve offset/range inline behavior for rich diffs and unified diffs
Browse Repository
Passed
No Audits
fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Revisions
D21256: Give selected inline comments are more obvious selected state
Browse Repository
Passed
No Audits
b021da71a52d When users click headers to select diff UI elements, don't eat the events
Author
epriestley
Revisions
D21255: When users click headers to select diff UI elements, don't eat the events
Browse Repository
Passed
No Audits
42f1a95a1255 Fix a flash of document selection when "oncopy" and "inline on range" behaviors…
Author
epriestley
Revisions
D21254: Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact
Browse Repository
Passed
No Audits
f45519c0604b When cancelling an inline comment edit, exit the edit state after the response…
Author
epriestley
Revisions
D21253: When cancelling an inline comment edit, exit the edit state after the response arrives
Browse Repository
Passed
No Audits
cfb5de6fa77f Distinguish more carefully between "null" inline offsets and "0" inline offsets
Author
epriestley
Revisions
D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets
Browse Repository
Passed
No Audits
2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Revisions
D21250: Store inline comment offset information and show it when highlighting comments
Browse Repository
Passed
No Audits
ebef22ccc1bb Improve select-to-comment behavior in Firefox and on unified diffs
Author
epriestley
Revisions
D21249: Improve select-to-comment behavior in Firefox and on unified diffs
Browse Repository
Passed
No Audits
42378ea393fe Allow users to create inline comments by directly selecting text directly
Author
epriestley
Revisions
D21248: Allow users to create inline comments by directly selecting text directly
Browse Repository
Passed
No Audits
c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Revisions
D21246: Add "View Raw Remarkup" to inline comments
Browse Repository
Passed
No Audits
419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Revisions
D21244: Move inline comment actions into a dropdown menu
Browse Repository
Passed
No Audits
1da54837ea8a Improve line breaking behavior in Firefox and Chrome under complex conditions
Author
epriestley
Revisions
D21247: Improve line breaking behavior in Firefox and Chrome under complex conditions
Browse Repository
Passed
No Audits
3dea92081bbe Fix an issue where passphrase-protected private keys were stored without…
Author
epriestley
Revisions
D21245: Fix an issue where passphrase-protected private keys were stored without discarding passphrases
Browse Repository
Passed
No Audits
df139f044b9b Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Author
epriestley
Revisions
D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Browse Repository
Passed
No Audits
e8109e4a9224 When an inline was left on a rendered DocumentEngine document, don't include an…
Author
epriestley
Revisions
D21242: When an inline was left on a rendered DocumentEngine document, don't include an email context patch
Browse Repository
Passed
No Audits
acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Revisions
D21241: Make "View as Document Type..." only show valid options
Browse Repository
Passed
No Audits
0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Revisions
D21240: When creating an inline, save the current document engine
Browse Repository
Passed
No Audits
6dc20d1e2e71 Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Author
epriestley
Revisions
D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Browse Repository
Passed
No Audits

Changes (30)

Path

Size

resources/

celerity/

map.php

src/

applications/

almanac/

util/

AlmanacKeys.php

auth/

sshkey/

PhabricatorAuthSSHPrivateKey.php

celerity/

postprocessor/

CelerityDefaultPostprocessor.php

differential/

mail/

DifferentialInlineCommentMailView.php

parser/

DifferentialChangesetParser.php

render/

DifferentialChangesetHTMLRenderer.php

DifferentialChangesetOneUpRenderer.php

DifferentialChangesetTwoUpRenderer.php

view/

DifferentialChangesetListView.php

files/

diff/

PhabricatorDocumentEngineBlocks.php

passphrase/

controller/

PassphraseCredentialViewController.php

system/

controller/

PhabricatorSystemSelectViewAsController.php

transactions/

storage/

PhabricatorApplicationTransactionComment.php

infrastructure/

diff/

PhabricatorInlineCommentController.php

interface/

PhabricatorInlineComment.php

view/

PHUIDiffInlineCommentDetailView.php

PHUIDiffInlineCommentView.php

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

view/

phui/

PHUITimelineEventView.php

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

phui-inline-comment.css

core/

syntax.css

z-index.css

phui/

phui-property-list-view.css

js/

application/

diff/

core/

phuix/

rP686e51655bb0

View Options

resources/celerity/map.php

View Options

src/applications/almanac/util/AlmanacKeys.php

View Options

src/applications/auth/sshkey/PhabricatorAuthSSHPrivateKey.php

View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

View Options

src/applications/differential/mail/DifferentialInlineCommentMailView.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

View Options

src/applications/differential/view/DifferentialChangesetListView.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

View Options

src/applications/system/controller/PhabricatorSystemSelectViewAsController.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

View Options

src/view/phui/PHUITimelineEventView.php

View Options

webroot/rsrc/css/application/differential/changeset-view.css

View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

View Options

webroot/rsrc/css/core/syntax.css

View Options

webroot/rsrc/css/core/z-index.css

View Options

webroot/rsrc/css/phui/phui-property-list-view.css

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

View Options

webroot/rsrc/js/core/behavior-oncopy.js

View Options

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

(stable) Promote 2020 Week 19Audit Required686e51655bb0Actions

Description

Details

Event Timeline

Merged Changes

Changes (30)

rP686e51655bb0

resources/celerity/map.php

src/applications/almanac/util/AlmanacKeys.php

src/applications/auth/sshkey/PhabricatorAuthSSHPrivateKey.php

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

src/applications/differential/mail/DifferentialInlineCommentMailView.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

src/applications/differential/view/DifferentialChangesetListView.php

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

src/applications/passphrase/controller/PassphraseCredentialViewController.php

src/applications/system/controller/PhabricatorSystemSelectViewAsController.php

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

src/infrastructure/diff/PhabricatorInlineCommentController.php

src/infrastructure/diff/interface/PhabricatorInlineComment.php

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

src/view/phui/PHUITimelineEventView.php

webroot/rsrc/css/application/differential/changeset-view.css

webroot/rsrc/css/application/differential/phui-inline-comment.css

webroot/rsrc/css/core/syntax.css

webroot/rsrc/css/core/z-index.css

webroot/rsrc/css/phui/phui-property-list-view.css

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffInline.js

webroot/rsrc/js/core/behavior-oncopy.js

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

(stable) Promote 2020 Week 19
Audit Required686e51655bb0
Actions