Page MenuHomePhabricator
Differential D21264

Fix an email address validation UI feedback issue when creating new users
ClosedPublic
Actions

Authored by epriestley on May 18 2020, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:22 AM
Unknown Object (File)
Fri, Mar 29, 11:53 AM
Unknown Object (File)
Sun, Mar 24, 8:27 PM
Unknown Object (File)
Feb 23 2024, 10:01 PM
Unknown Object (File)
Jan 28 2024, 5:14 AM
Unknown Object (File)
Jan 26 2024, 3:47 PM
Unknown Object (File)
Dec 25 2023, 6:35 AM
Unknown Object (File)
Dec 25 2023, 2:25 AM
View All 51 Files
Subscribers
None

Details

Reviewers
None
Commits
rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users
Summary

On the "New User" web workflow, if you use an invalid email address, you get a failure with an empty message.

Test Plan
  • Before: Tried to create a new user with address "asdf". Got no specific guidance.
  • After: Got specific guidance about email address formatting and length.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 18 2020, 2:33 PM
Harbormaster completed remote builds in B24453: Diff 50634.May 18 2020, 2:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 18 2020, 2:34 PM
epriestley requested review of this revision.
Closed by commit rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
5 lines

Diff 50635

View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Loading...
Phabricator · Built by Phacility