Fix an email address validation UI feedback issue when creating new users
ClosedPublic
Actions

Authored by epriestley on May 18 2020, 2:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 1:06 PM

	Unknown Object (File)
	Mon, Dec 16, 5:53 AM

	Unknown Object (File)
	Fri, Dec 13, 8:03 AM

	Unknown Object (File)
	Wed, Dec 11, 1:12 PM

	Unknown Object (File)
	Sun, Dec 1, 6:38 PM

	Unknown Object (File)
	Sun, Dec 1, 5:40 PM

	Unknown Object (File)
	Nov 23 2024, 5:58 AM

	Unknown Object (File)
	Nov 9 2024, 4:15 PM

View All 97 Files

Subscribers

None

Details

Reviewers: None
Commits: rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users

Summary

On the "New User" web workflow, if you use an invalid email address, you get a failure with an empty message.

Test Plan

Before: Tried to create a new user with address "asdf". Got no specific guidance.
After: Got specific guidance about email address formatting and length.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 18 2020, 2:33 PM

Harbormaster completed remote builds in B24453: Diff 50634.May 18 2020, 2:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 18 2020, 2:34 PM

epriestley requested review of this revision.

Closed by commit rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleNewController.php

5 lines

Diff 50635

View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Fix an email address validation UI feedback issue when creating new usersClosedPublicActions