- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 14 2020
May 14 2020
epriestley requested review of D21256: Give selected inline comments are more obvious selected state.
epriestley committed rARCb76b9c4065bb: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()" (authored by epriestley).
Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()"
epriestley requested review of D21251: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()".
epriestley committed rP2f5398796e02: Store inline comment offset information and show it when highlighting comments (authored by epriestley).
Store inline comment offset information and show it when highlighting comments
epriestley committed rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs (authored by epriestley).
Improve select-to-comment behavior in Firefox and on unified diffs
epriestley committed rP42378ea393fe: Allow users to create inline comments by directly selecting text directly (authored by epriestley).
Allow users to create inline comments by directly selecting text directly
epriestley committed rPc063e0e5ec9d: Add "View Raw Remarkup" to inline comments (authored by epriestley).
Add "View Raw Remarkup" to inline comments
epriestley committed rP419b7ceebb0f: Move inline comment actions into a dropdown menu (authored by epriestley).
Move inline comment actions into a dropdown menu
May 13 2020
May 13 2020
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
- In Jupyter notebooks (and, theoretically, other rich content) we find an inner <td /> before finding the content <td />, preventing context menus from working.
epriestley requested review of D21249: Improve select-to-comment behavior in Firefox and on unified diffs.
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
- In Firefox, multi-line selections don't generate a context menu properly.
- Clicking the "New Inline Comment" action disables the oncopy behavior onmousedown but doesn't take the action until onclick. This creates a flash of selected content which spans both sides of the change and looks odd.
- Context selection doesn't activate in unified mode, maybe because data-copy stuff is being used to identify content cells.
epriestley committed rP1da54837ea8a: Improve line breaking behavior in Firefox and Chrome under complex conditions (authored by epriestley).
Improve line breaking behavior in Firefox and Chrome under complex conditions
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
- When you create an inline, do nothing, then click "Cancel", inlines briefly count themselves in the paths panel.
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
I have a patch which allows you to edit published inlines. It "works", but it causes a ton of weird side effects when you perform an edit.
epriestley committed rP3dea92081bbe: Fix an issue where passphrase-protected private keys were stored without… (authored by epriestley).
Fix an issue where passphrase-protected private keys were stored without…
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
Inline stuff:
May 12 2020
May 12 2020
epriestley committed rPdf139f044b9b: Render proper "Show Context" links in DocumentEngine diffs, not just bullets (authored by epriestley).
Render proper "Show Context" links in DocumentEngine diffs, not just bullets
epriestley committed rPe8109e4a9224: When an inline was left on a rendered DocumentEngine document, don't include an… (authored by epriestley).
When an inline was left on a rendered DocumentEngine document, don't include an…
epriestley committed rPacc1fa165519: Make "View as Document Type..." only show valid options (authored by epriestley).
Make "View as Document Type..." only show valid options
epriestley committed rP0cca40db3bc6: When creating an inline, save the current document engine (authored by epriestley).
When creating an inline, save the current document engine
- Also restrict the list for changes with no candidate engines.
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
Probably kicking this, but:
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
See PHI1703. The document engine the original comment was made on should be persisted, so email can do something better than dumping unrelated lines of text into the body.
The SSH username change wasn't sufficient because there's a hard-coded piece of logic to select the username by instance name:
May 8 2020
May 8 2020
epriestley committed rPebf254dac351: (stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine (authored by epriestley).
(stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine
epriestley committed rP6dc20d1e2e71: Fix an issue where storage inlines are fed to InlineAdjustmentEngine (authored by epriestley).
Fix an issue where storage inlines are fed to InlineAdjustmentEngine
epriestley requested review of D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine.
(stable) Promote 2020 Week 18
(stable) Promote 2020 Week 18
epriestley added a comment to T13532: Git commit hooks may mutate commits in "arc land", discarding "Differential Revision: ...".
If pre-commit can not mutate the commit
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
The preview section underneath the comment area doesn't mark "editing" inlines in any special way.
epriestley committed rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing… (authored by epriestley).
Make "Delete" from inline comment previews function correctly while editing…
epriestley committed rPb804e8cffad2: Make "View" from inline comment previews correctly jump to "isEditing" inlines (authored by epriestley).
Make "View" from inline comment previews correctly jump to "isEditing" inlines
epriestley committed rP24ba66f106f2: Persist "Show Changeset" and improve path text selection (authored by epriestley).
Persist "Show Changeset" and improve path text selection
epriestley committed rPfa2d30ee3698: Lift inline comment draft behaviors to "InlineController" (authored by epriestley).
Lift inline comment draft behaviors to "InlineController"