Page MenuHomePhabricator
Feed All Stories

May 14 2020

epriestley requested review of D21256: Give selected inline comments are more obvious selected state.
May 14 2020, 8:19 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21256: Give selected inline comments are more obvious selected state.
May 14 2020, 8:18 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21255: When users click headers to select diff UI elements, don't eat the events.
May 14 2020, 6:47 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21255: When users click headers to select diff UI elements, don't eat the events.
May 14 2020, 6:46 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21254: Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact.
May 14 2020, 6:41 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21254: Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact.
May 14 2020, 6:40 PM · Inline Comments, Diffusion, Differential
epriestley triaged T13535: Investigate PHP 7.4 Preloading as Wishlist priority.
May 14 2020, 6:26 PM · Infrastructure
epriestley requested review of D21253: When cancelling an inline comment edit, exit the edit state after the response arrives.
May 14 2020, 6:20 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21253: When cancelling an inline comment edit, exit the edit state after the response arrives.
May 14 2020, 6:19 PM · Inline Comments, Diffusion, Differential
epriestley triaged T13534: Inline Comment errata after editing persistence as Wishlist priority.
May 14 2020, 6:13 PM · Differential
epriestley requested review of D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets.
May 14 2020, 5:58 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets.
May 14 2020, 5:57 PM · Inline Comments, Diffusion, Differential
epriestley committed rARCb76b9c4065bb: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()" (authored by epriestley).
Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()"
May 14 2020, 4:16 PM
epriestley closed T13533: Support arbitrary cURL options, for Kerberos auth as Resolved by committing rARCb76b9c4065bb: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()".
May 14 2020, 4:16 PM · Infrastructure
epriestley closed D21251: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()".
May 14 2020, 4:16 PM
epriestley requested review of D21251: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()".
May 14 2020, 4:15 PM
epriestley added a revision to T13533: Support arbitrary cURL options, for Kerberos auth: D21251: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()".
May 14 2020, 4:14 PM · Infrastructure
epriestley triaged T13533: Support arbitrary cURL options, for Kerberos auth as Wishlist priority.
May 14 2020, 3:54 PM · Infrastructure
epriestley committed rP2f5398796e02: Store inline comment offset information and show it when highlighting comments (authored by epriestley).
Store inline comment offset information and show it when highlighting comments
May 14 2020, 12:22 AM
epriestley closed D21250: Store inline comment offset information and show it when highlighting comments.
May 14 2020, 12:21 AM
epriestley committed rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs (authored by epriestley).
Improve select-to-comment behavior in Firefox and on unified diffs
May 14 2020, 12:20 AM
epriestley closed D21249: Improve select-to-comment behavior in Firefox and on unified diffs.
May 14 2020, 12:19 AM
epriestley committed rP42378ea393fe: Allow users to create inline comments by directly selecting text directly (authored by epriestley).
Allow users to create inline comments by directly selecting text directly
May 14 2020, 12:15 AM
epriestley closed D21248: Allow users to create inline comments by directly selecting text directly.
May 14 2020, 12:15 AM
epriestley committed rPc063e0e5ec9d: Add "View Raw Remarkup" to inline comments (authored by epriestley).
Add "View Raw Remarkup" to inline comments
May 14 2020, 12:14 AM
epriestley closed D21246: Add "View Raw Remarkup" to inline comments.
May 14 2020, 12:14 AM
epriestley committed rP419b7ceebb0f: Move inline comment actions into a dropdown menu (authored by epriestley).
Move inline comment actions into a dropdown menu
May 14 2020, 12:13 AM
epriestley closed D21244: Move inline comment actions into a dropdown menu.
May 14 2020, 12:13 AM

May 13 2020

epriestley requested review of D21250: Store inline comment offset information and show it when highlighting comments.
May 13 2020, 11:56 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21250: Store inline comment offset information and show it when highlighting comments.
May 13 2020, 11:55 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In Jupyter notebooks (and, theoretically, other rich content) we find an inner <td /> before finding the content <td />, preventing context menus from working.
May 13 2020, 11:05 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21249: Improve select-to-comment behavior in Firefox and on unified diffs.
May 13 2020, 8:48 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21249: Improve select-to-comment behavior in Firefox and on unified diffs.
May 13 2020, 8:47 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In Firefox, multi-line selections don't generate a context menu properly.
  • Clicking the "New Inline Comment" action disables the oncopy behavior onmousedown but doesn't take the action until onclick. This creates a flash of selected content which spans both sides of the change and looks odd.
  • Context selection doesn't activate in unified mode, maybe because data-copy stuff is being used to identify content cells.
May 13 2020, 8:20 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21248: Allow users to create inline comments by directly selecting text directly.
May 13 2020, 8:18 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21248: Allow users to create inline comments by directly selecting text directly.
May 13 2020, 8:17 PM · Inline Comments, Diffusion, Differential
epriestley committed rP1da54837ea8a: Improve line breaking behavior in Firefox and Chrome under complex conditions (authored by epriestley).
Improve line breaking behavior in Firefox and Chrome under complex conditions
May 13 2020, 6:54 PM
epriestley closed D21247: Improve line breaking behavior in Firefox and Chrome under complex conditions.
May 13 2020, 6:54 PM
epriestley requested review of D21247: Improve line breaking behavior in Firefox and Chrome under complex conditions.
May 13 2020, 6:54 PM
epriestley requested review of D21246: Add "View Raw Remarkup" to inline comments.
May 13 2020, 4:32 PM
epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: D21246: Add "View Raw Remarkup" to inline comments.
May 13 2020, 4:31 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21246: Add "View Raw Remarkup" to inline comments.
May 13 2020, 4:31 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • When you create an inline, do nothing, then click "Cancel", inlines briefly count themselves in the paths panel.
May 13 2020, 4:30 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
May 13 2020, 4:19 PM · Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I have a patch which allows you to edit published inlines. It "works", but it causes a ton of weird side effects when you perform an edit.

May 13 2020, 4:18 PM · Inline Comments, Diffusion, Differential
epriestley committed rP3dea92081bbe: Fix an issue where passphrase-protected private keys were stored without… (authored by epriestley).
Fix an issue where passphrase-protected private keys were stored without…
May 13 2020, 3:14 PM
epriestley closed D21245: Fix an issue where passphrase-protected private keys were stored without discarding passphrases.
May 13 2020, 3:14 PM
epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: D21245: Fix an issue where passphrase-protected private keys were stored without discarding passphrases.
May 13 2020, 3:09 PM · Auth
epriestley updated the summary of D21245: Fix an issue where passphrase-protected private keys were stored without discarding passphrases.
May 13 2020, 3:09 PM
epriestley requested review of D21245: Fix an issue where passphrase-protected private keys were stored without discarding passphrases.
May 13 2020, 3:06 PM
epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: D21245: Fix an issue where passphrase-protected private keys were stored without discarding passphrases.
May 13 2020, 3:05 PM · Passphrase
epriestley requested review of D21244: Move inline comment actions into a dropdown menu.
May 13 2020, 12:58 PM
epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: D21244: Move inline comment actions into a dropdown menu.
May 13 2020, 12:57 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21244: Move inline comment actions into a dropdown menu.
May 13 2020, 12:57 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Inline stuff:

May 13 2020, 12:43 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13229: On Third-Party Integrations.
May 13 2020, 12:01 AM · Phacility

May 12 2020

epriestley committed rPdf139f044b9b: Render proper "Show Context" links in DocumentEngine diffs, not just bullets (authored by epriestley).
Render proper "Show Context" links in DocumentEngine diffs, not just bullets
May 12 2020, 11:09 PM
epriestley closed D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets.
May 12 2020, 11:09 PM
epriestley requested review of D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets.
May 12 2020, 11:01 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets.
May 12 2020, 11:00 PM · Inline Comments, Diffusion, Differential
epriestley committed rPe8109e4a9224: When an inline was left on a rendered DocumentEngine document, don't include an… (authored by epriestley).
When an inline was left on a rendered DocumentEngine document, don't include an…
May 12 2020, 9:34 PM
epriestley closed D21242: When an inline was left on a rendered DocumentEngine document, don't include an email context patch.
May 12 2020, 9:34 PM
epriestley committed rPacc1fa165519: Make "View as Document Type..." only show valid options (authored by epriestley).
Make "View as Document Type..." only show valid options
May 12 2020, 9:25 PM
epriestley closed D21241: Make "View as Document Type..." only show valid options.
May 12 2020, 9:25 PM
epriestley committed rP0cca40db3bc6: When creating an inline, save the current document engine (authored by epriestley).
When creating an inline, save the current document engine
May 12 2020, 9:25 PM
epriestley closed D21240: When creating an inline, save the current document engine.
May 12 2020, 9:25 PM
epriestley requested review of D21242: When an inline was left on a rendered DocumentEngine document, don't include an email context patch.
May 12 2020, 9:10 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21242: When an inline was left on a rendered DocumentEngine document, don't include an email context patch.
May 12 2020, 9:09 PM · Inline Comments, Diffusion, Differential
epriestley updated the diff for D21241: Make "View as Document Type..." only show valid options.
  • Also restrict the list for changes with no candidate engines.
May 12 2020, 8:38 PM
epriestley requested review of D21241: Make "View as Document Type..." only show valid options.
May 12 2020, 8:34 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21241: Make "View as Document Type..." only show valid options.
May 12 2020, 8:33 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21240: When creating an inline, save the current document engine.
May 12 2020, 7:20 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21240: When creating an inline, save the current document engine.
May 12 2020, 7:19 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Probably kicking this, but:

May 12 2020, 6:31 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

See PHI1703. The document engine the original comment was made on should be persisted, so email can do something better than dumping unrelated lines of text into the body.

May 12 2020, 6:29 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13529: Phacility domain rename errata and SSH user identity.

The SSH username change wasn't sufficient because there's a hard-coded piece of logic to select the username by instance name:

May 12 2020, 6:20 PM · Phacility

May 8 2020

epriestley committed rPebf254dac351: (stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine (authored by epriestley).
(stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine
May 8 2020, 11:56 PM
epriestley committed rP6dc20d1e2e71: Fix an issue where storage inlines are fed to InlineAdjustmentEngine (authored by epriestley).
Fix an issue where storage inlines are fed to InlineAdjustmentEngine
May 8 2020, 11:56 PM
epriestley closed D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine.
May 8 2020, 11:56 PM
epriestley requested review of D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine.
May 8 2020, 11:53 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine.
May 8 2020, 11:51 PM · Inline Comments, Diffusion, Differential
epriestley edited the content of Changelog.
May 8 2020, 9:24 PM
epriestley created an object: 2020 Week 18 (Early May).
May 8 2020, 9:22 PM
epriestley committed rARC22363974e2e0: (stable) Promote 2020 Week 18 (authored by epriestley).
(stable) Promote 2020 Week 18
May 8 2020, 9:20 PM
epriestley committed rPc358cff7bd72: (stable) Promote 2020 Week 18 (authored by epriestley).
(stable) Promote 2020 Week 18
May 8 2020, 9:20 PM
epriestley added a comment to T13532: Git commit hooks may mutate commits in "arc land", discarding "Differential Revision: ...".

If pre-commit can not mutate the commit

May 8 2020, 9:02 PM · Arcanist
epriestley closed T13531: Phacility cluster account/service sync issues (account identifiers, instance refs) as Resolved.
May 8 2020, 6:49 PM · Phacility
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

The preview section underneath the comment area doesn't mark "editing" inlines in any special way.

May 8 2020, 3:56 PM · Inline Comments, Diffusion, Differential
epriestley committed rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing… (authored by epriestley).
Make "Delete" from inline comment previews function correctly while editing…
May 8 2020, 3:54 PM
epriestley closed D21238: Make "Delete" from inline comment previews function correctly while editing comments.
May 8 2020, 3:54 PM
epriestley committed rPb804e8cffad2: Make "View" from inline comment previews correctly jump to "isEditing" inlines (authored by epriestley).
Make "View" from inline comment previews correctly jump to "isEditing" inlines
May 8 2020, 3:52 PM
epriestley closed D21237: Make "View" from inline comment previews correctly jump to "isEditing" inlines.
May 8 2020, 3:52 PM
epriestley requested review of D21238: Make "Delete" from inline comment previews function correctly while editing comments.
May 8 2020, 3:11 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21238: Make "Delete" from inline comment previews function correctly while editing comments.
May 8 2020, 3:09 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21237: Make "View" from inline comment previews correctly jump to "isEditing" inlines.
May 8 2020, 2:52 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21237: Make "View" from inline comment previews correctly jump to "isEditing" inlines.
May 8 2020, 2:51 PM · Inline Comments, Diffusion, Differential
epriestley committed rP24ba66f106f2: Persist "Show Changeset" and improve path text selection (authored by epriestley).
Persist "Show Changeset" and improve path text selection
May 8 2020, 1:59 PM
epriestley closed D21236: Persist "Show Changeset" and improve path text selection.
May 8 2020, 1:59 PM
epriestley committed rPfa2d30ee3698: Lift inline comment draft behaviors to "InlineController" (authored by epriestley).
Lift inline comment draft behaviors to "InlineController"
May 8 2020, 1:52 PM
epriestley closed D21235: Lift inline comment draft behaviors to "InlineController".
May 8 2020, 1:52 PM