Page MenuHomePhabricator

Allow construction of a ConduitEngine with a bare ConduitClient
ClosedPublic

Authored by epriestley on May 15 2020, 3:23 PM.
Tags
None
Referenced Files
F18985488: D21260.id50624.diff
Mon, Nov 17, 1:04 PM
F18920693: D21260.id50625.diff
Sun, Nov 9, 1:14 PM
F18735543: D21260.id50624.diff
Oct 1 2025, 2:11 AM
F18734296: D21260.id.diff
Sep 30 2025, 10:51 PM
F18446314: D21260.id50625.diff
Aug 31 2025, 9:28 PM
F18392583: D21260.id50624.diff
Aug 29 2025, 8:24 AM
F18391552: D21260.id50625.diff
Aug 29 2025, 7:40 AM
F18388865: D21260.diff
Aug 29 2025, 5:09 AM
Subscribers
None

Details

Summary

See PHI1735. "ConduitEngine" was once a future pool, but this has moved to "HardpointEngine". This class may no longer make much sense.

In Phacility code, "bin/host upload" depends on using the Uploader, which needs a "ConduitEngine", not a "ConduitClient". This workflow may use asymmetric key signing, which "ConduitEngine" does not support.

To unblock PHI1735, provide glue code between "Client" and "Engine". But a "more correct" change is probably removal of "Engine".

Test Plan
  • Ran bin/host upload, uploaded files (with additional changes to wrap the Client).
  • Created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 3:24 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.