Page MenuHomePhabricator

Allow construction of a ConduitEngine with a bare ConduitClient
ClosedPublic

Authored by epriestley on Fri, May 15, 3:23 PM.

Details

Summary

See PHI1735. "ConduitEngine" was once a future pool, but this has moved to "HardpointEngine". This class may no longer make much sense.

In Phacility code, "bin/host upload" depends on using the Uploader, which needs a "ConduitEngine", not a "ConduitClient". This workflow may use asymmetric key signing, which "ConduitEngine" does not support.

To unblock PHI1735, provide glue code between "Client" and "Engine". But a "more correct" change is probably removal of "Engine".

Test Plan
  • Ran bin/host upload, uploaded files (with additional changes to wrap the Client).
  • Created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 15, 3:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 15, 3:24 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.