Page MenuHomePhabricator
Create Task
Maniphest T13529

Phacility domain rename errata and SSH user identity
Open, NormalPublic
Actions

Description

  • The "Domains" breadcrumb on a domain detail page doesn't link to the right place.
  • The OAuth "access denied" dialog uses the instance internal name, not the instance display name, after an instance rename. This is because it's using the OAuth application name, which isn't propagated by the rename.
  • See PHI1721. After a rename, the SSH username is still the old instance name. Instead, all x in x.phacility.com should map to the instance (they likely do) and the config should choose the primary x.phacility.com to generate the SSH username.

Revisions and Commits

Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
rP Phabricator
D21259rPb1351d0fdb81 Remove code which overrides "diffusion.ssh-username" when instanced

Related Objects

Event Timeline

epriestley triaged this task as Wishlist priority.May 1 2020, 4:34 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptMay 1 2020, 4:34 PM
epriestley updated the task description. (Show Details)May 1 2020, 4:39 PM
epriestley renamed this task from Phacility domain errata to Phacility domain rename errata and SSH user identity.May 1 2020, 5:25 PM
epriestley raised the priority of this task from Wishlist to Normal.
epriestley updated the task description. (Show Details)
epriestley added a commit: Restricted Diffusion Commit.May 8 2020, 6:55 PM
epriestley added a commit: Restricted Diffusion Commit.May 8 2020, 8:36 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a comment.May 12 2020, 6:20 PM

The SSH username change wasn't sufficient because there's a hard-coded piece of logic to select the username by instance name:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/almanac/util/AlmanacKeys.php$60-67

This can likely be removed now, although it dates from D15754 (April 2016) and diffusion.ssh-user should be set after 9370875d20b (Feb 2015), so I'm slightly suspicious that I'm missing something.

epriestley added a revision: D21259: Remove code which overrides "diffusion.ssh-username" when instanced.May 15 2020, 1:31 PM
epriestley added a commit: rPb1351d0fdb81: Remove code which overrides "diffusion.ssh-username" when instanced.May 15 2020, 2:45 PM
Phabricator · Built by Phacility