When cancelling an inline comment edit, exit the edit state after the response…
f45519c0604b
Actions

Description

When cancelling an inline comment edit, exit the edit state after the response arrives

Summary: Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan:

Clicked a line number.
Typed some text.
Clicked "Cancel".
Before patch: paths panel flashes "1".
After patch: paths panel stays stable.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21253

Details

Provenance

epriestley	Authored on May 14 2020, 6:17 PM
epriestley	Pushed on May 14 2020, 9:28 PM

Differential Revision

D21253: When cancelling an inline comment edit, exit the edit state after the response arrives

Parents

rPcfb5de6fa77f: Distinguish more carefully between "null" inline offsets and "0" inline offsets

Branches

Unknown

Tags

Unknown

Tasks

T13513: Make schema changes to inlines to prepare for new inline features

Build Status

Buildable 24431
Build 33665: Run Core Tests

Event Timeline

epriestley committed rPf45519c0604b: When cancelling an inline comment edit, exit the edit state after the response… (authored by epriestley).May 14 2020, 9:28 PM

epriestley added a task: T13513: Make schema changes to inlines to prepare for new inline features.

epriestley added an edge: D21253: When cancelling an inline comment edit, exit the edit state after the response arrives.

Harbormaster completed building B24431: rPf45519c0604b: When cancelling an inline comment edit, exit the edit state after the response….May 14 2020, 9:29 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

rPf45519c0604b

View Options

resources/celerity/map.php