Page MenuHomePhabricator
Feed All Stories

Oct 17 2019

epriestley closed D20858: Fix deprecated argument order for "implode()".
Oct 17 2019, 4:11 PM
epriestley closed T13428: PHP 7.4 now warns about "implode()" argument order as Resolved by committing rP5dafabd5b4d0: Fix deprecated argument order for "implode()".
Oct 17 2019, 4:11 PM · Infrastructure
epriestley committed rARCda6d4f85eefb: Add a lint check for deprecated argument order to "implode()" (authored by epriestley).
Add a lint check for deprecated argument order to "implode()"
Oct 17 2019, 4:09 PM
epriestley closed D20857: Add a lint check for deprecated argument order to "implode()".
Oct 17 2019, 4:09 PM
epriestley requested review of D20858: Fix deprecated argument order for "implode()".
Oct 17 2019, 4:09 PM
epriestley updated the task description for T13428: PHP 7.4 now warns about "implode()" argument order.
Oct 17 2019, 4:08 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: D20858: Fix deprecated argument order for "implode()".
Oct 17 2019, 4:07 PM · Infrastructure
epriestley requested review of D20857: Add a lint check for deprecated argument order to "implode()".
Oct 17 2019, 4:06 PM
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: D20857: Add a lint check for deprecated argument order to "implode()".
Oct 17 2019, 4:05 PM · Infrastructure
epriestley added a task to D20846: Fix "implode()" argument order in query string construction: T13428: PHP 7.4 now warns about "implode()" argument order.
Oct 17 2019, 4:03 PM
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: D20846: Fix "implode()" argument order in query string construction.
Oct 17 2019, 4:03 PM · Infrastructure
epriestley triaged T13428: PHP 7.4 now warns about "implode()" argument order as Low priority.
Oct 17 2019, 4:03 PM · Infrastructure

Oct 15 2019

Krinkle added a comment to T13421: Implement OpenGraph metadata in Phame for Twitter cards.

I did some trial and error last week with Twitter via https://cards-dev.twitter.com/validator. That was for my personal blog, but some of it might apply here as well.

Oct 15 2019, 12:46 AM · Phame
Krinkle updated Krinkle.
Oct 15 2019, 12:19 AM
Krinkle updated Krinkle.
Oct 15 2019, 12:18 AM
Krinkle updated Krinkle.
Oct 15 2019, 12:17 AM

Oct 14 2019

artms added a project to T13427: Task to reproduce lack of transaction object validation: artms.
Oct 14 2019, 11:46 AM · artms
artms created T13427: Task to reproduce lack of transaction object validation.
Oct 14 2019, 11:45 AM · artms

Oct 11 2019

mormegil awarded rPff410134818e: Support animated gif in meme a Love token.
Oct 11 2019, 1:50 PM

Oct 10 2019

epriestley added a comment to T13322: Allow parent projects to have direct members.

See PHI1492. After this change, the parent/subproject modes of the script in T10350 can be brought upstream safely, since they would no longer be destructive operations on membership lists. This wouldn't cover the "convert a project into a milestone" mode, but that seems less important.

Oct 10 2019, 2:51 PM · Projects
epriestley added a parent task for T10350: Scripts to migrate old "points" fields and move projects beneath other projects: T13322: Allow parent projects to have direct members.
Oct 10 2019, 2:50 PM · Projects (v3)
epriestley added a subtask for T13322: Allow parent projects to have direct members: T10350: Scripts to migrate old "points" fields and move projects beneath other projects.
Oct 10 2019, 2:50 PM · Projects
epriestley added a task to D20856: Allow partial response of transaction history if it is overheating: T13416: Transaction logs may overheat explosively.
Oct 10 2019, 2:35 PM
epriestley added a revision to T13416: Transaction logs may overheat explosively: D20856: Allow partial response of transaction history if it is overheating.
Oct 10 2019, 2:35 PM · Feed
artms requested review of D20856: Allow partial response of transaction history if it is overheating.
Oct 10 2019, 1:48 PM

Oct 9 2019

artms requested review of D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 9 2019, 8:01 AM

Oct 8 2019

20after4 awarded T13419: Fully modularize object relationships, to support custom relationships like "Subtask/Parent Task" a Love token.
Oct 8 2019, 9:57 PM · Infrastructure

Oct 7 2019

slashsBin updated slashsBin.
Oct 7 2019, 11:06 PM

Oct 3 2019

woodings added a comment to E1672: Test demo.

1231231

Oct 3 2019, 5:29 PM

Oct 2 2019

epriestley committed rP9d644f1bfea1: (stable) Use "git log ... --stdin" instead of "git log ... --not ..." to avoid… (authored by epriestley).
(stable) Use "git log ... --stdin" instead of "git log ... --not ..." to avoid…
Oct 2 2019, 9:13 PM
epriestley committed rPed7d22142a99: (stable) When a large number of commits need to be marked as published, issue… (authored by epriestley).
(stable) When a large number of commits need to be marked as published, issue…
Oct 2 2019, 9:12 PM
epriestley committed rP7badec23a7d0: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized… (authored by epriestley).
Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized…
Oct 2 2019, 9:08 PM
epriestley closed D20854: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines.
Oct 2 2019, 9:08 PM
epriestley committed rP6d74736a7ec8: When a large number of commits need to be marked as published, issue the lookup… (authored by epriestley).
When a large number of commits need to be marked as published, issue the lookup…
Oct 2 2019, 9:06 PM
epriestley closed D20853: When a large number of commits need to be marked as published, issue the lookup query in chunks.
Oct 2 2019, 9:06 PM
epriestley requested review of D20854: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines.
Oct 2 2019, 8:30 PM
epriestley requested review of D20853: When a large number of commits need to be marked as published, issue the lookup query in chunks.
Oct 2 2019, 8:13 PM
artms committed rP960c447aab7f: Support more than 9 portals (authored by artms).
Support more than 9 portals
Oct 2 2019, 7:36 PM
artms closed D20852: Support more than 9 portals.
Oct 2 2019, 7:36 PM
epriestley committed rP344a2e39bed7: In Jupyter notebooks, apply intraline diffing to source code lines (authored by epriestley).
In Jupyter notebooks, apply intraline diffing to source code lines
Oct 2 2019, 7:35 PM
epriestley closed D20851: In Jupyter notebooks, apply intraline diffing to source code lines.
Oct 2 2019, 7:35 PM
epriestley accepted D20852: Support more than 9 portals.

Thanks!

Oct 2 2019, 7:33 PM
artms requested review of D20852: Support more than 9 portals.
Oct 2 2019, 7:32 PM
epriestley requested review of D20851: In Jupyter notebooks, apply intraline diffing to source code lines.
Oct 2 2019, 3:51 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20851: In Jupyter notebooks, apply intraline diffing to source code lines.
Oct 2 2019, 3:50 PM · Differential
epriestley committed rP7c83076fb68e: (stable) Fix an issue where any diff which could possibly be rendered as… (authored by epriestley).
(stable) Fix an issue where any diff which could possibly be rendered as…
Oct 2 2019, 1:53 AM
epriestley committed rP9f7aaa8ee4cb: Fix an issue where any diff which could possibly be rendered as Jupyter decided… (authored by epriestley).
Fix an issue where any diff which could possibly be rendered as Jupyter decided…
Oct 2 2019, 1:52 AM
epriestley closed D20850: Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter.
Oct 2 2019, 1:52 AM
epriestley requested review of D20850: Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter.
Oct 2 2019, 1:52 AM

Oct 1 2019

mcorteel awarded T13410: Update Phriction UI structural behaviors a Love token.
Oct 1 2019, 6:32 AM · Phriction

Sep 30 2019

epriestley edited the content of Changelog.
Sep 30 2019, 6:12 PM
epriestley committed rPHU1750586fdc50: (stable) Promote 2019 Week 39 (authored by epriestley).
(stable) Promote 2019 Week 39
Sep 30 2019, 6:08 PM
epriestley committed rP256507a14e0d: (stable) Promote 2019 Week 39 (authored by epriestley).
(stable) Promote 2019 Week 39
Sep 30 2019, 6:08 PM
epriestley created an object: 2019 Week 39 (Very Late September).
Sep 30 2019, 6:08 PM
epriestley committed rP76d9912932bc: Force unified abstract block diffs into roughly usable shape (authored by epriestley).
Force unified abstract block diffs into roughly usable shape
Sep 30 2019, 5:44 PM
epriestley closed D20848: Force unified abstract block diffs into roughly usable shape.
Sep 30 2019, 5:44 PM
epriestley committed rPd9515e82a3ec: Perform basic block interdiffs when diffing abstract blocks, and interdiff… (authored by epriestley).
Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Sep 30 2019, 5:43 PM
epriestley closed D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks.
Sep 30 2019, 5:43 PM
epriestley committed rP5afdc620db59: Make basic Juypter notebook rendering improvements and roughly support folding… (authored by epriestley).
Make basic Juypter notebook rendering improvements and roughly support folding…
Sep 30 2019, 5:41 PM
epriestley closed D20844: Make basic Juypter notebook rendering improvements and roughly support folding unchanged context.
Sep 30 2019, 5:41 PM
epriestley committed rPa7f3316aa3df: Improve sequencing of various content/header checks in abstract block diffs (authored by epriestley).
Improve sequencing of various content/header checks in abstract block diffs
Sep 30 2019, 5:40 PM
epriestley closed D20843: Improve sequencing of various content/header checks in abstract block diffs.
Sep 30 2019, 5:40 PM
epriestley requested review of D20848: Force unified abstract block diffs into roughly usable shape.
Sep 30 2019, 5:36 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20848: Force unified abstract block diffs into roughly usable shape.
Sep 30 2019, 5:34 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

Context isn't automatically unfolding around inlines, but should.

Sep 30 2019, 5:28 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

Oh, and maybe lack of source code intraline diffs, although that's likely not too much work.

Sep 30 2019, 5:24 PM · Differential
epriestley committed rP9944b669ade9: Make HTTP/403 say "Yikes!" (authored by epriestley).
Make HTTP/403 say "Yikes!"
Sep 30 2019, 4:27 PM
epriestley closed D20847: Make HTTP/403 say "Yikes!".
Sep 30 2019, 4:27 PM
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

I think the major remaining issues are:

Sep 30 2019, 4:26 PM · Differential
epriestley requested review of D20847: Make HTTP/403 say "Yikes!".
Sep 30 2019, 4:22 PM
epriestley committed rPHU39ed96cd818a: Fix "implode()" argument order in query string construction (authored by epriestley).
Fix "implode()" argument order in query string construction
Sep 30 2019, 4:18 PM
epriestley closed D20846: Fix "implode()" argument order in query string construction.
Sep 30 2019, 4:18 PM
epriestley requested review of D20846: Fix "implode()" argument order in query string construction.
Sep 30 2019, 4:17 PM

Sep 28 2019

epriestley edited the content of Migrating Repository Shards.
Sep 28 2019, 2:59 PM · Phacility
epriestley edited the content of Phacility Cluster Documentation.
Sep 28 2019, 2:59 PM
epriestley created an object: Migrating Repository Shards.
Sep 28 2019, 2:59 PM · Phacility
epriestley requested review of D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks.
Sep 28 2019, 12:27 AM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks.
Sep 28 2019, 12:25 AM · Differential

Sep 27 2019

epriestley requested review of D20844: Make basic Juypter notebook rendering improvements and roughly support folding unchanged context.
Sep 27 2019, 9:33 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20844: Make basic Juypter notebook rendering improvements and roughly support folding unchanged context.
Sep 27 2019, 9:31 PM · Differential
epriestley requested review of D20843: Improve sequencing of various content/header checks in abstract block diffs.
Sep 27 2019, 8:19 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20843: Improve sequencing of various content/header checks in abstract block diffs.
Sep 27 2019, 8:18 PM · Differential
epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

One broad problem here is "chain of custody" issues in T182. A "Saved State" can easily accommodate multiple representations, and the plan above imagines using Drydock to build tags/branches out of non-repository representations, so we'd have cases where a given "Saved State" has a way to build it with a "patch list" (from the client) or a "ref pointer" (from Drydock).

Sep 27 2019, 6:43 PM · Harbormaster, Drydock, Arcanist
epriestley triaged T13426: Add a "Saved States" indirection layer on top of "Staging Areas" as Normal priority.
Sep 27 2019, 6:28 PM · Harbormaster, Drydock, Arcanist
epriestley committed rPf004b76465fe: Add a "Subtype" tag to the task graph view in Maniphest (authored by epriestley).
Add a "Subtype" tag to the task graph view in Maniphest
Sep 27 2019, 5:59 PM
epriestley closed D20842: Add a "Subtype" tag to the task graph view in Maniphest.
Sep 27 2019, 5:59 PM
epriestley requested review of D20842: Add a "Subtype" tag to the task graph view in Maniphest.
Sep 27 2019, 5:55 PM
epriestley added a comment to T524: OpenID Authentication as an Auth Option.

OIDC is just OAuth2 in a ghost costume, so the implementation is nearly trivial.

Sep 27 2019, 1:54 AM · Phabricator
storrgie added a comment to T524: OpenID Authentication as an Auth Option.

Apologies, I should have provided more context. We've been futzing with this project which OIDC. We'd be looking to ensure that it works with Dex.

Sep 27 2019, 1:18 AM · Phabricator
epriestley added a comment to T524: OpenID Authentication as an Auth Option.

I'm not sure how I'd even test OpenID these days. Offhand, I haven't seen any provider offering OpenID in years.

Sep 27 2019, 1:16 AM · Phabricator
storrgie added a comment to T524: OpenID Authentication as an Auth Option.

Would you considered taking prioritized funding for implementing OpenID?

Sep 27 2019, 1:04 AM · Phabricator

Sep 26 2019

epriestley committed rP7a0090f4d070: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly (authored by epriestley).
Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
Sep 26 2019, 7:04 PM
epriestley closed D20841: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly.
Sep 26 2019, 7:03 PM
epriestley requested review of D20841: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly.
Sep 26 2019, 6:49 PM
epriestley committed rP2c06815edb0f: When rendering Jupyter notebook diffs, split code inputs into individual blocks (authored by epriestley).
When rendering Jupyter notebook diffs, split code inputs into individual blocks
Sep 26 2019, 4:05 AM
epriestley closed D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks.
Sep 26 2019, 4:05 AM
epriestley updated the task description for T11860: Bot email addresses can't be edited.
Sep 26 2019, 4:03 AM · Setup, People
epriestley requested review of D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks.
Sep 26 2019, 2:53 AM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks.
Sep 26 2019, 2:51 AM · Differential

Sep 25 2019

epriestley committed rP884cd74cc4a5: In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better (authored by epriestley).
In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
Sep 25 2019, 11:51 PM