Differential D20845

Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks
ClosedPublic
Actions

Authored by epriestley on Sep 28 2019, 12:25 AM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rPd9515e82a3ec: Perform basic block interdiffs when diffing abstract blocks, and interdiff…

Summary

Depends on D20844. Ref T13425. When we line up two blocks and they can be interdiffed (generally: they both have the same type of content), let the Engine interdiff them.

Then, make the Jupyter engine interdiff markdown.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 28 2019, 12:25 AM

Harbormaster completed remote builds in B23516: Diff 49689.Sep 28 2019, 12:27 AM

epriestley requested review of this revision.Sep 28 2019, 12:27 AM

epriestley added a child revision: D20848: Force unified abstract block diffs into roughly usable shape.Sep 30 2019, 5:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 5:43 PM

Closed by commit rPd9515e82a3ec: Perform basic block interdiffs when diffing abstract blocks, and interdiff… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd9515e82a3ec: Perform basic block interdiffs when diffing abstract blocks, and interdiff….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

differential/

parser/

DifferentialChangesetParser.php

19 lines

render/

DifferentialChangesetOneUpRenderer.php

2 lines

DifferentialChangesetRenderer.php

11 lines

DifferentialChangesetTwoUpRenderer.php

76 lines

files/

diff/

PhabricatorDocumentEngineBlock.php

14 lines

PhabricatorDocumentEngineBlockDiff.php

47 lines

PhabricatorDocumentEngineBlocks.php

4 lines

document/

PhabricatorDocumentEngine.php

24 lines

PhabricatorImageDocumentEngine.php

18 lines

PhabricatorJupyterDocumentEngine.php

182 lines

Diff 49697

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlockDiff.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

View Options

src/applications/files/document/PhabricatorDocumentEngine.php

View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49697

src/__phutil_library_map__.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

src/applications/differential/render/DifferentialChangesetRenderer.php

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

src/applications/files/diff/PhabricatorDocumentEngineBlockDiff.php

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

src/applications/files/document/PhabricatorDocumentEngine.php

src/applications/files/document/PhabricatorImageDocumentEngine.php

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks
ClosedPublic
Actions

Revision Contents
Changeset List