Page MenuHomePhabricator

Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines

Authored by epriestley on Oct 2 2019, 8:28 PM.



Depends on D20853. See PHI1474. If the list of "--not" refs is sufficiently long, we may exceed the maximum size of a command.

Use "--stdin" instead, and swap "--not" for the slightly less readable but functionally equivalent "^hash", which has the advantage of actually working with "--stdin".

Test Plan

Ran bin/repository refs ... with nothing to be done, and with something to be done.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 2 2019, 8:28 PM
epriestley requested review of this revision.Oct 2 2019, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 9:08 PM
This revision was automatically updated to reflect the committed changes.