Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines
ClosedPublic
Actions

Authored by epriestley on Oct 2 2019, 8:28 PM.

Details

Reviewers: None
Commits: rP9d644f1bfea1: (stable) Use "git log ... --stdin" instead of "git log ... --not ..." to avoid…
rP7badec23a7d0: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized…

Summary

Depends on D20853. See PHI1474. If the list of "--not" refs is sufficiently long, we may exceed the maximum size of a command.

Use "--stdin" instead, and swap "--not" for the slightly less readable but functionally equivalent "^hash", which has the advantage of actually working with "--stdin".

Test Plan

Ran bin/repository refs ... with nothing to be done, and with something to be done.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 2 2019, 8:28 PM

Harbormaster completed remote builds in B23541: Diff 49713.Oct 2 2019, 8:30 PM

epriestley requested review of this revision.Oct 2 2019, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 9:08 PM

Closed by commit rP7badec23a7d0: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7badec23a7d0: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized….

epriestley added a commit: rP9d644f1bfea1: (stable) Use "git log ... --stdin" instead of "git log ... --not ..." to avoid….Oct 2 2019, 9:12 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryRefEngine.php

25 lines

Diff 49715

View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command linesClosedPublicActions