Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
F15409496: D20850.id49704.diff
Wed, Mar 19, 4:36 AM
F15398989: D20850.id49703.diff
Mon, Mar 17, 2:15 AM
F15337530: D20850.diff
Sun, Mar 9, 6:14 AM
Unknown Object (File)
Feb 9 2025, 8:16 AM
Unknown Object (File)
Feb 9 2025, 8:16 AM
Unknown Object (File)
Feb 9 2025, 8:16 AM
Unknown Object (File)
Feb 9 2025, 8:16 AM
Unknown Object (File)
Jan 29 2025, 8:23 AM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable