Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
F18802919: D20850.id.diff
Fri, Oct 17, 8:52 PM
F18788088: D20850.id49703.diff
Wed, Oct 15, 2:46 AM
F18760206: D20850.diff
Mon, Oct 6, 8:32 AM
F18734074: D20850.id.diff
Tue, Sep 30, 10:47 PM
F18704556: D20850.id49704.diff
Sun, Sep 28, 8:05 AM
F18570855: D20850.id49704.diff
Sep 10 2025, 4:11 AM
F18570852: D20850.id49703.diff
Sep 10 2025, 4:10 AM
F18567454: D20850.id.diff
Sep 9 2025, 3:47 PM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable