Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
F19581539: D20850.id49704.diff
Sun, Feb 1, 7:26 PM
F19543850: D20850.diff
Fri, Jan 23, 12:05 AM
F19467879: D20850.diff
Jan 3 2026, 6:48 PM
F19083094: D20850.id49704.diff
Dec 2 2025, 12:30 PM
F19036103: D20850.diff
Nov 25 2025, 7:01 PM
F18999256: D20850.id49703.diff
Nov 20 2025, 8:43 PM
F18985245: D20850.id49703.diff
Nov 17 2025, 12:57 PM
F18979809: D20850.diff
Nov 16 2025, 10:59 PM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable