Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
F15486427: D20850.id49704.diff
Thu, Apr 10, 7:06 AM
F15481695: D20850.id49704.diff
Tue, Apr 8, 10:26 PM
F15481694: D20850.id49703.diff
Tue, Apr 8, 10:26 PM
F15481691: D20850.id.diff
Tue, Apr 8, 10:26 PM
F15477745: D20850.diff
Mon, Apr 7, 5:33 PM
F15468821: D20850.id49704.diff
Fri, Apr 4, 6:15 AM
F15468432: D20850.id49703.diff
Fri, Apr 4, 12:41 AM
F15466546: D20850.id49704.diff
Thu, Apr 3, 6:49 AM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable