Page MenuHomePhabricator

2019 Week 39 (Very Late September)
Updated 1,890 Days AgoPublic

Summary of changes from September 23, 2019 to September 30, 2019.

CodebaseRepositoryHEADActivity
PhabricatorrPrP76d991293225 commits
ArcanistrARCrARC3cdfe1ff0 commits
libphutilrPHUrPHU39ed96c3 commits
Instances (SAAS)rSAASrSAAS7ecf93d0 commits
Services (SAAS)rSERVICESrSERVICESc4bd1190 commits
Core (SAAS)rCORErCORE6ff31671 commit
  • These changes were promoted to stable.

General

  • No notes in this period.

Security

  • No notes in this period.

Migrations

MigrationRiskDurationNotes
20190924.diffusion.01.permanent.sql573 ms
20190924.diffusion.02.default.sql54 ms

"Duration" is the duration for this install, and may not be representative.

Upgrading / Compatibility

[] Anchor Changes: Some anchor behavior in Remarkup has changed slightly. These changes generally should have very little impact on existing installs, but may be worth keeping an eye on.

  • You can now use any prefix of an anchor in a URL to scroll to it; for example, #example will scroll to #example-long-anchor-name.
  • The remarkup anchor generation algorithm has changed slightly. In general, it now tries to generate more readable anchors. In most cases, old anchors are either unchanged, or are valid aliases of new anchors under the "prefix rule".
  • A new {anchor #xyz} rule allows you to specify anchors in documents.
  • See T13410 for context and plans.

[] Unpublished Commits Reachable from Permanent Refs: A bug where commits which are reachable from a permanent ref could fail to publish in certain circumstances has been fixed. There were two cases where this could occur:

  • If a ref was initially nonpermanent, then later was reconfigured to be permanent, known-but-unpublished commits reachable from the ref at the time it was made permanent might not be published.
  • During initial import, commits reachable from permanent refs might not be marked as published.

These issues have been fixed, but the fix is not retroactive, so you'll need to repair affected repositories manually if you have affected commits. This bug is generally cosmetic and doesn't have significant implications, so it's not particularly important to hunt down affected commits or repair this exhaustively.

To repair an affected repository which has commits that are reachable from one or more permanent refs but which are marked as unpublished:

  • Stop the daemons.
  • Put the repository in "importing" mode. This is necessary to prevent the affected commits from sending email and taking other publishing actions when they are published.
  • Rebuild the repository refs.
  • Start the daemons.

To put a repository in "importing" mode, do this:

phabricator/ $ ./bin/repository mark-imported --mark-not-imported <repository>

To rebuild refs, do this:

phabricator/ $ ./bin/repository refs --rebuild <repository> [--trace] [--verbose]

See T13284 for more detailed discussion.

Other Changes

  • PhutilProseDiff and a few related classes have moved from libphutil/ to phabricator/.

Minor

  • [] arc liberate now ignores all files in src/extensions/, not just top-level files.
  • Fixed an issue where paging Conduit call logs could fail.
  • Fixed an implode() call which warns under recent versions of PHP.
  • Administrators can now provide custom instructions for requesting a username change (in AuthMessages).
  • [] Prose diffs now work better when the initial inputs are large.
  • [] Maniphest task graphs now show task subtypes.
  • [] Fixed a bug where the bulk editor interacted poorly with composite typeahead datasources.

The [] icon indicates a change backed by support mana.

Last Author
epriestley
Last Edited
Sep 30 2019, 6:08 PM