Differential D20855

Add index on dateCreated database field because it is used by Feed->Transactions functionality
AbandonedPublic
Actions

Authored by epriestley on Oct 9 2019, 8:00 AM.

Details

Reviewers

Pawka
artms

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13416: Transaction logs may overheat explosively

Summary

It is very expensive to fetch transaction history when you have large transaction history, Feed->Transactions functionality times out in our production environment where differential_transaction has >32million+ records

Test Plan

Added indexes
Checked Feed->Transaction it is no longer timing out

Diff Detail

Repository

rP Phabricator

Branch

transaction-created

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23550
Build 32363: Run Core Tests
Build 32362: arc lint + arc unit

Event Timeline

artms created this revision.Oct 9 2019, 8:00 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 9 2019, 8:00 AM

artms planned changes to this revision.Oct 9 2019, 8:00 AM

Harbormaster completed remote builds in B23550: Diff 49722.Oct 9 2019, 8:01 AM

artms requested review of this revision.Oct 9 2019, 8:01 AM

Herald added a subscriber: Korvin. · View Herald TranscriptOct 9 2019, 8:01 AM

artms added a task: T13416: Transaction logs may overheat explosively.Oct 22 2019, 7:43 AM

Please file bug reports via Discourse or, if applicable, your organization's support channel.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

3 lines

Diff 49722

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Add index on dateCreated database field because it is used by Feed->Transactions functionalityAbandonedPublicActions