Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 7:47 PM
Unknown Object (File)
Fri, Nov 15, 4:08 AM
Unknown Object (File)
Mon, Nov 11, 2:08 PM
Unknown Object (File)
Sat, Nov 9, 3:51 PM
Unknown Object (File)
Thu, Nov 7, 3:28 AM
Unknown Object (File)
Thu, Oct 24, 2:30 PM
Unknown Object (File)
Oct 2 2024, 5:05 AM
Unknown Object (File)
Sep 22 2024, 10:42 PM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable