Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 4 2025, 11:51 AM
Unknown Object (File)
Apr 1 2025, 5:34 PM
Unknown Object (File)
Mar 28 2025, 11:17 AM
Unknown Object (File)
Mar 28 2025, 11:17 AM
Unknown Object (File)
Mar 28 2025, 8:22 AM
Unknown Object (File)
Mar 25 2025, 10:04 PM
Unknown Object (File)
Mar 22 2025, 6:45 PM
Unknown Object (File)
Mar 19 2025, 10:14 PM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable