Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F18816717: D20843.diff
Tue, Oct 21, 8:57 AM
F18813764: D20843.diff
Mon, Oct 20, 6:52 PM
F18734069: D20843.id.diff
Tue, Sep 30, 10:47 PM
F18684246: D20843.diff
Fri, Sep 26, 8:57 AM
F18684211: D20843.diff
Fri, Sep 26, 8:52 AM
F18684162: D20843.diff
Fri, Sep 26, 8:47 AM
F18632237: D20843.diff
Sep 16 2025, 5:28 PM
F18626693: D20843.diff
Sep 16 2025, 1:51 AM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable