Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F22557884: D20843.diff
Wed, Sep 23, 7:15 PM
F22540212: D20843.diff
Tue, Sep 22, 12:43 PM
Unknown Object (File)
Jul 7 2026, 9:58 PM
Unknown Object (File)
Jul 7 2026, 9:04 AM
Unknown Object (File)
Jul 3 2026, 6:42 AM
Unknown Object (File)
Jul 1 2026, 1:19 AM
Unknown Object (File)
Jun 15 2026, 10:23 PM
Unknown Object (File)
Apr 11 2026, 9:10 AM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable