Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F18626693: D20843.diff
Tue, Sep 16, 1:51 AM
F18618068: D20843.diff
Sun, Sep 14, 11:05 PM
F18570816: D20843.id49695.diff
Wed, Sep 10, 4:09 AM
F18570813: D20843.id49687.diff
Wed, Sep 10, 4:09 AM
F18567445: D20843.id.diff
Tue, Sep 9, 3:47 PM
F18563325: D20843.diff
Tue, Sep 9, 7:00 AM
F18481861: D20843.id49687.diff
Wed, Sep 3, 1:25 PM
F18380188: D20843.id49695.diff
Thu, Aug 28, 5:21 PM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable