Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F17638653: D20843.id49695.diff
Fri, Jul 11, 4:53 PM
Unknown Object (File)
Sat, Jun 28, 1:16 PM
Unknown Object (File)
Fri, Jun 27, 4:14 PM
Unknown Object (File)
Mon, Jun 16, 1:02 PM
Unknown Object (File)
May 18 2025, 2:56 AM
Unknown Object (File)
Apr 4 2025, 11:51 AM
Unknown Object (File)
Apr 1 2025, 5:34 PM
Unknown Object (File)
Mar 28 2025, 11:17 AM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable