Page MenuHomePhabricator

When rendering Jupyter notebook diffs, split code inputs into individual blocks
ClosedPublic

Authored by epriestley on Thu, Sep 26, 2:51 AM.

Details

Summary

Ref T13425. Currently, code inputs and all outputs are grouped into a single block. This is fine for display notebooks but not great for diffing notebooks.

Instead, split source code input into individual lines with one line per block, and each output into its own block.

This allows you to leave actual line-by-line inlines on source, and comment on outputs individually.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Sep 26, 2:51 AM
epriestley requested review of this revision.Thu, Sep 26, 2:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Sep 26, 4:05 AM
This revision was automatically updated to reflect the committed changes.