Page MenuHomePhabricator

When rendering Jupyter notebook diffs, split code inputs into individual blocks
ClosedPublic

Authored by epriestley on Sep 26 2019, 2:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 10:55 PM
Unknown Object (File)
Feb 11 2024, 12:02 PM
Unknown Object (File)
Feb 10 2024, 9:39 PM
Unknown Object (File)
Feb 5 2024, 9:41 AM
Unknown Object (File)
Feb 3 2024, 11:17 PM
Unknown Object (File)
Jan 27 2024, 5:07 PM
Unknown Object (File)
Jan 26 2024, 2:01 PM
Unknown Object (File)
Dec 3 2023, 12:20 AM
Subscribers
None

Details

Summary

Ref T13425. Currently, code inputs and all outputs are grouped into a single block. This is fine for display notebooks but not great for diffing notebooks.

Instead, split source code input into individual lines with one line per block, and each output into its own block.

This allows you to leave actual line-by-line inlines on source, and comment on outputs individually.

Test Plan

Screen Shot 2019-09-25 at 7.40.45 PM.png (542×872 px, 92 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 4:05 AM
This revision was automatically updated to reflect the committed changes.