Page MenuHomePhabricator

When rendering Jupyter notebook diffs, split code inputs into individual blocks
ClosedPublic

Authored by epriestley on Sep 26 2019, 2:51 AM.
Tags
None
Referenced Files
F18985234: D20840.id49681.diff
Mon, Nov 17, 12:56 PM
F18824453: D20840.id.diff
Oct 23 2025, 3:46 PM
F18821867: D20840.diff
Oct 23 2025, 2:21 AM
F18813763: D20840.diff
Oct 20 2025, 6:52 PM
F18803393: D20840.id.diff
Oct 17 2025, 11:21 PM
F18759246: D20840.id49682.diff
Oct 6 2025, 2:39 AM
F18734067: D20840.id.diff
Sep 30 2025, 10:47 PM
F18670572: D20840.id49681.diff
Sep 25 2025, 12:44 AM
Subscribers
None

Details

Summary

Ref T13425. Currently, code inputs and all outputs are grouped into a single block. This is fine for display notebooks but not great for diffing notebooks.

Instead, split source code input into individual lines with one line per block, and each output into its own block.

This allows you to leave actual line-by-line inlines on source, and comment on outputs individually.

Test Plan

Screen Shot 2019-09-25 at 7.40.45 PM.png (542×872 px, 92 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 4:05 AM
This revision was automatically updated to reflect the committed changes.