Page MenuHomePhabricator
Differential D20851

In Jupyter notebooks, apply intraline diffing to source code lines
ClosedPublic
Actions

Authored by epriestley on Oct 2 2019, 3:50 PM.
Tags
None
Referenced Files
F18734075: D20851.id.diff
Tue, Sep 30, 10:47 PM
F18673867: D20851.diff
Thu, Sep 25, 12:23 PM
F18570864: D20851.id49710.diff
Wed, Sep 10, 4:11 AM
F18570858: D20851.id49706.diff
Wed, Sep 10, 4:11 AM
F18567456: D20851.id.diff
Tue, Sep 9, 3:47 PM
F18514453: D20851.id.diff
Sep 5 2025, 10:14 AM
F18511724: D20851.diff
Sep 5 2025, 6:59 AM
F18201411: D20851.id.diff
Aug 18 2025, 7:33 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rP344a2e39bed7: In Jupyter notebooks, apply intraline diffing to source code lines
Summary

Ref T13425. When we render a diff between two source lines, highlight intraline changes.

Test Plan

Viewed a Jupyter notebook with a code diff in it, saw the changed subsequences in the line highlighted.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 2 2019, 3:50 PM
Harbormaster completed remote builds in B23534: Diff 49706.Oct 2 2019, 3:51 PM
epriestley requested review of this revision.Oct 2 2019, 3:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 7:35 PM
Closed by commit rP344a2e39bed7: In Jupyter notebooks, apply intraline diffing to source code lines (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP344a2e39bed7: In Jupyter notebooks, apply intraline diffing to source code lines.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
files/
document/
62 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 49710

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility