Maniphest T13428

PHP 7.4 now warns about "implode()" argument order
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Oct 17 2019, 4:03 PM

Tags

Referenced Files

None

Subscribers

Description

PHP 7.4 has introduced a deprecation warning about implode(list, glue):

implode(): Passing glue string after array is deprecated. Swap the parameters.

See:

Revisions and Commits

rPHU libphutil
	Closed		D20846 Fix "implode()" argument order in query string construction
rARC Arcanist
		D20857	rARCda6d4f85eefb Add a lint check for deprecated argument order to "implode()"
rP Phabricator
		D20858	rP5dafabd5b4d0 Fix deprecated argument order for "implode()"

Event Timeline

epriestley triaged this task as Low priority.Oct 17 2019, 4:03 PM

epriestley created this task.

Herald added a subscriber: amckinley. · View Herald TranscriptOct 17 2019, 4:03 PM

epriestley added a revision: D20846: Fix "implode()" argument order in query string construction.Oct 17 2019, 4:03 PM

epriestley added a revision: D20857: Add a lint check for deprecated argument order to "implode()".Oct 17 2019, 4:05 PM

epriestley added a revision: D20858: Fix deprecated argument order for "implode()".Oct 17 2019, 4:07 PM

epriestley updated the task description. (Show Details)Oct 17 2019, 4:08 PM

epriestley added a commit: rARCda6d4f85eefb: Add a lint check for deprecated argument order to "implode()".Oct 17 2019, 4:09 PM

epriestley closed this task as Resolved by committing rP5dafabd5b4d0: Fix deprecated argument order for "implode()".Oct 17 2019, 4:11 PM

epriestley added a commit: rP5dafabd5b4d0: Fix deprecated argument order for "implode()".