Page MenuHomePhabricator

Add a lint check for deprecated argument order to "implode()"
ClosedPublic

Authored by epriestley on Thu, Oct 17, 4:05 PM.

Details

Summary

Ref T13428. Historically, "implode()" accepts arguments in either order. PHP 7.4+ warns about glue not being first.

Add a lint check when the second parameter is a static scalar, implying it is the glue parameter.

Test Plan

Ran unit tests. See next change.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.