Page MenuHomePhabricator

Fix deprecated argument order for "implode()"
ClosedPublic

Authored by epriestley on Oct 17 2019, 4:07 PM.
Tags
None
Referenced Files
F15498750: D20858.id49727.diff
Sun, Apr 13, 2:06 PM
F15490606: D20858.id49725.diff
Fri, Apr 11, 6:48 PM
F15481900: D20858.id49725.diff
Wed, Apr 9, 12:12 AM
F15480929: D20858.id.diff
Tue, Apr 8, 5:26 PM
F15476811: D20858.diff
Mon, Apr 7, 9:25 AM
F15473270: D20858.diff
Sat, Apr 5, 8:49 PM
F15454949: D20858.diff
Sat, Mar 29, 9:25 PM
F15451111: D20858.diff
Fri, Mar 28, 8:12 PM
Subscribers
None

Details

Summary

Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan

Used the linter introduced in D20857 to identify affected callsites.

$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.