Page MenuHomePhabricator

Fix deprecated argument order for "implode()"
ClosedPublic

Authored by epriestley on Oct 17 2019, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 9:38 AM
Unknown Object (File)
Feb 16 2024, 4:12 AM
Unknown Object (File)
Jan 30 2024, 10:20 AM
Unknown Object (File)
Jan 30 2024, 7:44 AM
Unknown Object (File)
Dec 26 2023, 9:32 AM
Unknown Object (File)
Dec 17 2023, 11:30 AM
Unknown Object (File)
Dec 13 2023, 10:29 AM
Unknown Object (File)
Nov 19 2023, 4:35 AM
Subscribers
None

Details

Summary

Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan

Used the linter introduced in D20857 to identify affected callsites.

$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.