Page MenuHomePhabricator

Fix deprecated argument order for "implode()"
ClosedPublic

Authored by epriestley on Oct 17 2019, 4:07 PM.
Tags
None
Referenced Files
F18815870: D20858.diff
Tue, Oct 21, 4:04 AM
F18783118: D20858.id.diff
Mon, Oct 13, 3:53 AM
F18754905: D20858.diff
Sun, Oct 5, 2:22 AM
F18734079: D20858.id.diff
Tue, Sep 30, 10:47 PM
F18703590: D20858.id49725.diff
Sun, Sep 28, 4:30 AM
F18623834: D20858.id.diff
Sep 15 2025, 5:48 PM
F18612616: D20858.diff
Sep 14 2025, 9:27 AM
F18570915: D20858.id49727.diff
Sep 10 2025, 4:12 AM
Subscribers
None

Details

Summary

Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan

Used the linter introduced in D20857 to identify affected callsites.

$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.