Page MenuHomePhabricator

Fix deprecated argument order for "implode()"
ClosedPublic

Authored by epriestley on Thu, Oct 17, 4:07 PM.

Details

Summary

Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan

Used the linter introduced in D20857 to identify affected callsites.

$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Oct 17, 4:07 PM
epriestley requested review of this revision.Thu, Oct 17, 4:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Oct 17, 4:11 PM
This revision was automatically updated to reflect the committed changes.