Page MenuHomePhabricator
Differential D20846

Fix "implode()" argument order in query string construction
ClosedPublic
Actions

Authored by epriestley on Sep 30 2019, 4:17 PM.
Tags
None
Referenced Files
F18854743: D20846.diff
Sat, Nov 1, 12:31 AM
F18851526: D20846.id.diff
Fri, Oct 31, 1:59 AM
F18828030: D20846.id.diff
Fri, Oct 24, 1:47 PM
F18823252: D20846.diff
Thu, Oct 23, 10:56 AM
F18684361: D20846.diff
Sep 26 2025, 9:12 AM
F18570842: D20846.id49691.diff
Sep 10 2025, 4:10 AM
F18570841: D20846.id49690.diff
Sep 10 2025, 4:10 AM
F18567451: D20846.id.diff
Sep 9 2025, 3:47 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13428: PHP 7.4 now warns about "implode()" argument order
Commits
rPHU1750586fdc50: (stable) Promote 2019 Week 39
rPHU39ed96cd818a: Fix "implode()" argument order in query string construction
Summary

See https://discourse.phabricator-community.org/t/libphutil-exception-when-using-with-newer-php-deprecated-use-of-implode/3159.

Test Plan

Grepped for other calls to implode(), didn't catch any with bad order.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
utils/
2 lines

Diff 49691

View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility