Page MenuHomePhabricator
Differential D20846

Fix "implode()" argument order in query string construction
ClosedPublic
Actions

Authored by epriestley on Sep 30 2019, 4:17 PM.

Details

Reviewers
None
Maniphest Tasks
T13428: PHP 7.4 now warns about "implode()" argument order
Commits
rPHU1750586fdc50: (stable) Promote 2019 Week 39
rPHU39ed96cd818a: Fix "implode()" argument order in query string construction
Summary

See https://discourse.phabricator-community.org/t/libphutil-exception-when-using-with-newer-php-deprecated-use-of-implode/3159.

Test Plan

Grepped for other calls to implode(), didn't catch any with bad order.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 30 2019, 4:17 PM
Harbormaster completed remote builds in B23517: Diff 49690.Sep 30 2019, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 4:17 PM
epriestley requested review of this revision.
Closed by commit rPHU39ed96cd818a: Fix "implode()" argument order in query string construction (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPHU39ed96cd818a: Fix "implode()" argument order in query string construction.
epriestley added a commit: rPHU1750586fdc50: (stable) Promote 2019 Week 39.Sep 30 2019, 6:08 PM
epriestley added a task: T13428: PHP 7.4 now warns about "implode()" argument order.Oct 17 2019, 4:03 PM

Revision Contents
Changeset List

PathSize
src/
utils/
2 lines

Diff 49691

View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility