Fix "implode()" argument order in query string construction
ClosedPublic
Actions

Authored by epriestley on Sep 30 2019, 4:17 PM.

Details

Reviewers: None
Maniphest Tasks: T13428: PHP 7.4 now warns about "implode()" argument order
Commits: rPHU1750586fdc50: (stable) Promote 2019 Week 39
rPHU39ed96cd818a: Fix "implode()" argument order in query string construction

Summary

Test Plan

Grepped for other calls to implode(), didn't catch any with bad order.

Repository

rPHU libphutil

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 4:17 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/utils/utils.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49690	f39a03d		Sep 30 2019, 4:17 PM	★	★
Diff 2	49691	f39a03d	rPHU39ed96cd818aae761ec92613a9ba0800824d0ab0	Sep 30 2019, 4:18 PM	★	★