Page MenuHomePhabricator

Fix an issue where the "viewer" is not passed to Bulk Edit controls properly

Authored by epriestley on Sep 26 2019, 6:47 PM.



See PHI1442. If you have a bulk-editable datasource field with a composite datasource, it can currently fatal on the bulk edit workflow because the viewer is not passed correctly.

The error looks something like this:

Argument 1 passed to PhabricatorDatasourceEngine::setViewer() must be an instance of PhabricatorUser, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php on line 231

Test Plan

Configured a Maniphest custom field with a composite datasource, then tried a bulk edit. Things worked cleanly instead of fataling.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 26 2019, 6:47 PM
epriestley requested review of this revision.Sep 26 2019, 6:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 7:03 PM
This revision was automatically updated to reflect the committed changes.