Differential D20856

Allow partial response of transaction history if it is overheating
AbandonedPublic
Actions

Authored by epriestley on Oct 10 2019, 1:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 1:22 AM

	Unknown Object (File)
	Sat, Jan 25, 5:56 AM

	Unknown Object (File)
	Sat, Jan 25, 5:56 AM

	Unknown Object (File)
	Fri, Jan 24, 5:28 AM

	Unknown Object (File)
	Wed, Jan 22, 11:54 AM

	Unknown Object (File)
	Tue, Jan 21, 9:56 AM

	Unknown Object (File)
	Dec 29 2024, 10:50 PM

	Unknown Object (File)
	Dec 20 2024, 11:15 AM

View All Files

Subscribers

Korvin

Details

Reviewers

Pawka
artms

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13416: Transaction logs may overheat explosively

Test Plan

Deployed changes
Opened Feed->Transation
No longer fails with

Unhandled Exception("Exception")
Query (of class "ConpherenceTransactionQuery") overheated: examined more than 1,010 raw rows without finding 101 visible objects.

Diff Detail

Repository

rP Phabricator

Branch

overheat

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23551
Build 32365: Run Core Tests
Build 32364: arc lint + arc unit

Event Timeline

artms created this revision.Oct 10 2019, 1:47 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 10 2019, 1:47 PM

Harbormaster completed remote builds in B23551: Diff 49723.Oct 10 2019, 1:48 PM

artms requested review of this revision.Oct 10 2019, 1:48 PM

Herald added a subscriber: Korvin. · View Herald TranscriptOct 10 2019, 1:48 PM

epriestley added a task: T13416: Transaction logs may overheat explosively.Oct 10 2019, 2:35 PM

Please file bug reports via Discourse or, if applicable, your organization's support channel.

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

query/

PhabricatorFeedTransactionQuery.php

1 line

Diff 49723

View Options

src/applications/feed/query/PhabricatorFeedTransactionQuery.php

Allow partial response of transaction history if it is overheatingAbandonedPublicActions