Page MenuHomePhabricator
Create Task
Maniphest T13280

Permanent Refs Errata
Open, NormalPublic
Actions

Description

Ideally, publish operations should act like this:

  • The "Acting As" PHID is the identity PHID associated with the commit. If one does not exist, the acting as PHID is the Diffusion application.
  • When we want to respect policies (Fixes Txxx), the acting user is the user associated with the identity, if one exists, or the omnipotent user if one does not.
  • The "Acting User" in Herald is the acting user associated with the identity, if one exists, or the Diffusion application, if one does not.

Boneyard

  • The git fetch change in D20421 may require an adjacent change to the two places where we call isWorkingCopyBare() before listing refs. I suspect we can now remove the special casing.
  • From D20436, we should go dig up the actual wire-proto.c in Git and verify the discovered protocol matches the implemented protocol.

Revisions and Commits

rP Phabricator
D20450rPa82a2b84599d Simplify non-bare working copy rules for the new "git fetch" strategy

Related Objects
Search...

Event Timeline

epriestley triaged this task as Normal priority.Apr 18 2019, 12:09 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptApr 18 2019, 12:09 PM
epriestley updated the task description. (Show Details)Apr 18 2019, 12:10 PM
epriestley mentioned this in D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.Apr 18 2019, 1:45 PM
epriestley added a comment.Apr 18 2019, 1:53 PM

The git fetch change in D20421 does actually affect non-bare repositories:

[2019-04-18 06:43:37] EXCEPTION: (CommandException) Command failed with error #128!
COMMAND
git fetch --prune -- '********' '+refs/heads/*:refs/heads/*' '+refs/tags/*:refs/tags/*'

STDOUT
(empty)

STDERR
fatal: Refusing to fetch into current branch refs/heads/master of non-bare repository

I'd like to get everyone off non-bare repositories, but it looks like we can cheat our way through this with --update-head-ok for now, and the other cases are also easy to resolve.

epriestley added a revision: D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.Apr 18 2019, 1:58 PM
epriestley added a commit: rPa82a2b84599d: Simplify non-bare working copy rules for the new "git fetch" strategy.Apr 19 2019, 2:06 PM
joshuaspence added a subscriber: joshuaspence.Apr 20 2019, 1:21 AM
epriestley moved this task from Backlog to "Track Only" on the Diffusion board.Apr 22 2019, 6:04 PM
epriestley updated the task description. (Show Details)Apr 23 2019, 4:28 PM
Phabricator · Built by Phacility