HomePhabricator
Diffusion Phabricator 42c02557e4e3

Remove all remaining readers and writers for TABLE_COMMIT
42c02557e4e3
Actions

Description

Remove all remaining readers and writers for TABLE_COMMIT

Summary: Depends on D20459. Ref T13276. I'll file a followup to actually destroy the table.

Test Plan:

  • Grepped for TABLE_COMMIT.
  • Ran bin/storage upgrade -f, got a clean bill of health.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13276

Differential Revision: https://secure.phabricator.com/D20461

Details

Provenance
epriestleyAuthored on Apr 22 2019, 7:38 PM
epriestleyPushed on Apr 24 2019, 12:55 PM
Reviewer
amckinley
Differential Revision
D20461: Remove all remaining readers and writers for TABLE_COMMIT
Parents
rPec0085fd0c7a: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Branches
Unknown
Tags
Unknown
Tasks
T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Build Status
Buildable 22710
Build 31128: Run Core Tests

Changes (3)

PathSize
src/
applications/
differential/
storage/
repository/
worker/
commitmessageparser/

rP42c02557e4e3

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/storage/DifferentialSchemaSpec.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator ยท Built by Phacility